Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.12.3: Security patch #117

Merged
merged 2 commits into from
Jul 22, 2019
Merged

v2.12.3: Security patch #117

merged 2 commits into from
Jul 22, 2019

Conversation

eatyourgreens
Copy link
Contributor

This updates outdated packages, including a security fix for lodash.

Copy link
Contributor

@rogerhutchings rogerhutchings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, and the tests pass 👍

@eatyourgreens
Copy link
Contributor Author

PJC doesn't have any tests for the API client itself. You have to install a pre-release version to PFE (or whichever app you want to test) in order to test it. 😞

@eatyourgreens
Copy link
Contributor Author

That said, json-api-client hasn't changed and that's the bit I'd think would be most likely to break.

@eatyourgreens eatyourgreens merged commit c4547d9 into master Jul 22, 2019
@eatyourgreens eatyourgreens deleted the security-patch branch July 22, 2019 11:11
@eatyourgreens eatyourgreens mentioned this pull request Jul 22, 2019
@rogerhutchings
Copy link
Contributor

It does, but only for auth and stats 🤦‍♂

@eatyourgreens
Copy link
Contributor Author

Dependabot should stage a PR on PFE with this patch, so we can test it that way. Not ideal, I know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants