Add default JSON headers to sign-out requests (#198)

Add the enumerable values of `config.jsonHeaders` to `deleteHeaders`, rather than creating a new, empty object from its prototype.
zooniverse · Feb 19, 2023 · b88b424 · b88b424
1 parent 6a4d6f6
commit b88b424
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/auth.js b/lib/auth.js
@@ -326,8 +326,10 @@ const authClient = new Model({
         return getCSRFToken(config.host).then(function(token) {
           var url = config.host + '/users/sign_out';
 
-          var deleteHeaders = Object.create(config.jsonHeaders);
-          deleteHeaders['X-CSRF-Token'] = token;
+          var deleteHeaders = {
+            ...config.jsonHeaders,
+            ['X-CSRF-Token']: token
+          };
 
           return makeCredentialHTTPRequest('DELETE', url, null, deleteHeaders)
             .then(function() {

diff --git a/lib/oauth.js b/lib/oauth.js
@@ -126,8 +126,10 @@ const authClient = new Model({
         return getCSRFToken(config.oauthHost).then(function(token) {
           var url = config.oauthHost + '/users/sign_out';
 
-          var deleteHeaders = Object.create(config.jsonHeaders);
-          deleteHeaders['X-CSRF-Token'] = token;
+          var deleteHeaders = {
+            ...config.jsonHeaders,
+            ['X-CSRF-Token']: token
+          };
 
           return makeCredentialHTTPRequest('DELETE', url, null, deleteHeaders)
             .then(function() {