This repository has been archived by the owner on Mar 12, 2020. It is now read-only.
[WIP] Use oauth module from PJC #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsravenous
force-pushed
the
use_pjc_oauth
branch
from
decff8a to
70a6a48
Compare
itsravenous
force-pushed
the
use_pjc_oauth
branch
from
c63179c to
52d3c28
Compare
|
Done with this I think - @saschaishikawa mind testing? |
|
@itsravenous: Looks good to me. That weird issue with "Skip all questions" disappearing remains. Merging anyway. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fully functional, but could do with going through and removing now-redundant code from the angular layer (caching and token refresh which are now handled by PJC). Closes #114 and #126