This repository has been archived by the owner on Jan 26, 2023. It is now read-only.
split makeHTTPRequest to distinct methods #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isolate the credentialed (user sessions) requests from non-credentialed (API) into distinct methods. This will fix ensure we don't run across CORS errors when using credentialed XMLHTTPRequests for open (wildcard) cors origins and will whitelist allowed cors origins for credentialed resource requests
srallen
reviewed
Nov 21, 2019
ensure makeHTTPRequest does not use credentials and makeCredentialHTTPRequest does by using an agent() instead of the singleton from the require
camallen
changed the title
|
this is ready for review, i've tested my local copy of PFE with this and zooniverse/panoptes-javascript-client#121 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isolate the credentialed (user sessions) requests from non-credentialed (API) into distinct methods.
This will fix ensure we don't run across CORS errors when using credentialed XMLHTTPRequests for open (wildcard) cors origins and will whitelist allowed cors origins for credentialed resource requests