Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

Add query params to PUT and POST #41

Merged
merged 1 commit into from
Nov 13, 2017
Merged

Conversation

eatyourgreens
Copy link
Contributor

Adds an optional query object argument to .save().
Passes that query down to the refresh() and request() methods so that query params can be added to the appropriate HTTP requests.

Closes #40

Adds an optional query object argument to .save().
Passes that query down to the refresh() and request() methods so that query params can be added to the appropriate HTTP requests.
Copy link
Contributor

@camallen camallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code here looks fine and i can't see this being a breaking change, really a minor version as it should be backwards compatible.

Can we deploy a PFE branch of pfe and pandora that uses this so we can test it?

@eatyourgreens
Copy link
Contributor Author

Sure. npm install PATH_TO_CLIENT to use a local version of the client, then deploy that version of PFE to S3.

@eatyourgreens
Copy link
Contributor Author

@camallen https://api-client.pfe-preview.zooniverse.org/ should be running this version of the client, instead of the npm package.

@eatyourgreens eatyourgreens merged commit c6dd8e4 into master Nov 13, 2017
@eatyourgreens eatyourgreens deleted the post-query-params branch November 13, 2017 12:28
@eatyourgreens
Copy link
Contributor Author

Published as 3.3.0. PFE is currently tied to 3.2.2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants