This repository has been archived by the owner on Jan 26, 2023. It is now read-only.
Revert "Return full response on error" #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edpaget
added a commit
that referenced
this pull request
Oct 2, 2015
Revert "Return full response on error"
|
How does this play with what the front-end current expects? |
|
Doesn't match up yet. Requires edpaget/Panoptes-Front-End#4 to adjust the error handler to throw the proper error message. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After spending more than a couple minutes looking at this, returning
erris correct here.erris both anErrorobject, and includes the original request and response. How I didn't catch that yesterday I don't know.I already published 2.0.0, so will publish 3.0.0 after merging.