Skip to content
This repository has been archived by the owner on Jan 26, 2023. It is now read-only.

Update to use superagent #14

Merged
merged 10 commits into from
Sep 14, 2015
Merged

Update to use superagent #14

merged 10 commits into from
Sep 14, 2015

Conversation

edpaget
Copy link
Contributor

@edpaget edpaget commented Aug 19, 2015

Also remove the need to build the project before requiring it

Also remove the need to build the project before requiring it
@edpaget
Copy link
Contributor Author

edpaget commented Aug 19, 2015

This looks fine running with the Front-End to me. I can start adding tests to the project if we want to make sure I didn't break anything.

@chrissnyder
Copy link
Contributor

Is this good to merge? Also seemed to run fine to me.

@edpaget
Copy link
Contributor Author

edpaget commented Sep 9, 2015

Yeah I think this is good to go along with the PFE pull request, but brian is in transit today.

@chrissnyder
Copy link
Contributor

OK, I think this is solid now. Unless someone brings up a reason not to, I'm going to merge this in this afternoon, then bump the version.

@edpaget
Copy link
Contributor Author

edpaget commented Sep 14, 2015

@chrissnyder Can you bump the major version, so it doesn't get automatically picked up by the front-end deploy?

@chrissnyder
Copy link
Contributor

Yep

On Mon, Sep 14, 2015 at 12:51 PM, Edward Paget [email protected]
wrote:

@chrissnyder https://github.com/chrissnyder Can you bump the major
version, so it doesn't get automatically picked up by the front-end deploy?


Reply to this email directly or view it on GitHub
#14 (comment)
.

chrissnyder added a commit that referenced this pull request Sep 14, 2015
@chrissnyder chrissnyder merged commit 77ab280 into zooniverse:master Sep 14, 2015
@edpaget edpaget deleted the superagent branch September 14, 2015 20:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants