Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Kenya database #5

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Add Kenya database #5

merged 2 commits into from
Mar 24, 2021

Conversation

shaunanoordin
Copy link
Member

@shaunanoordin shaunanoordin commented Mar 24, 2021

PR Overview

This PR adds the kenya database (for WildWatch Kenya)

The Kenya database...

  • consists of 3 tables: aggregations, subjects, cameras
  • the aggregations are for survey WF 11374 (production)
  • the subjects are from subject set 77507 only. We're using a small pool for now to test that the classrooms work.
  • the cameras list was provided by the WW Kenya team at San Diego Zoo

In this PR...

  • the docker files are updated to ensure Datasette recognises the kenya files
  • a kenya.zip was added to /data
    • ❗ Wait, something's not right here. The /data/kenya.zip ain't recognised for git add.
    • @camallen in commit 287802d, the .gitignore was updated to specifically "ignore the data file", i.e. data/**/* (Wait, how are the gorongosa.zip and darien.zip still in the repo? Does .gitignore not work retroactively on files that were already added?)
    • Q: is the .gitignore supposed to prevent additional .zip files to be added to the /data folder (e.g. to prevent gargantuan diffs from binary files), or is this some wildcard wonkiness? My default action is to disable .gitignore, git add kenya.zip, commit, then restore .gitignore, but I thought I'd check with you first.

Status

WIP, waiting on info on the .zip file.

@shaunanoordin shaunanoordin requested a review from camallen March 24, 2021 16:26
Copy link
Contributor

@camallen camallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM

Re the data - that is a scratch space for local dev and to avoid csv files (large) etc being added to the git repo accidentally I ignored that directory on purpose.

Simple way to get your data in is to:

1. Modify your local .gitignore to comment out this line https://github.com/zooniverse/classroom-maps-api/blob/4c4eab831b862edb47d52948ef11bbe14cbcb088/.gitignore#L2
2. check in your zip file (aiming for archives smaller than 10MB - we can switch away from zip archives if needed)
3. reset the .gitignore file to not accidentally check in data / csv files.

@shaunanoordin shaunanoordin marked this pull request as ready for review March 24, 2021 17:55
@shaunanoordin
Copy link
Member Author

👍 Thanks Cam! I've git-added the Kenya.zip file so this PR is good to go. Noted on the 10MB recommended limit - at the moment I have Kenya sitting at 5MB, but I'll keep an eye on the size as we add more Subjects to the archive.

@shaunanoordin shaunanoordin merged commit 1ded1dc into main Mar 24, 2021
@camallen camallen deleted the add-kenya-database branch March 24, 2021 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants