Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix password change and reset errors #6436

Closed
wants to merge 1 commit into from

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Feb 21, 2023

Test out API client changes that should fix password reset and password change when the client and API are not on the same origin.

Staging branch URL: https://pr-6436.pfe-preview.zooniverse.org

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

@coveralls
Copy link

coveralls commented Feb 21, 2023

Coverage Status

Coverage: 57.415% (-0.007%) from 57.422% when pulling ac9354e on credentialed-requests into 7ad87ae on master.

Test out API client changes that should fix password reset and password change when the client and API are not on the same origin.
@eatyourgreens
Copy link
Contributor Author

All tested and working now.

@eatyourgreens eatyourgreens deleted the credentialed-requests branch February 22, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants