Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated PJC and json-api-client to latest #5561

Merged
merged 1 commit into from
Nov 25, 2019
Merged

Updated PJC and json-api-client to latest #5561

merged 1 commit into from
Nov 25, 2019

Conversation

srallen
Copy link
Contributor

@srallen srallen commented Nov 22, 2019

Staging branch URL: https://pr-5561.pfe-preview.zooniverse.org

Updated PJC and json-api-client to the release candidates

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you rm -rf node_modules/ && npm install and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on Travis?

Optional

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.07%) to 49.167% when pulling cab0e00 on update-pjc into e52b9f3 on master.

Copy link
Contributor

@eatyourgreens eatyourgreens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can authenticate, and make authenticated requests, against both the staging and production APIs.

Tested on production with https://pr-5561.pfe-preview.zooniverse.org/projects/r-dot-bains/rodent-little-brother-secret-lives-of-mice/classify?env=production

@eatyourgreens eatyourgreens merged commit ea54be2 into master Nov 25, 2019
@eatyourgreens eatyourgreens deleted the update-pjc branch November 25, 2019 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants