Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Panoptes client to 2.8.1 #4316

Merged
merged 1 commit into from
Jan 24, 2018
Merged

Upgrade Panoptes client to 2.8.1 #4316

merged 1 commit into from
Jan 24, 2018

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Jan 24, 2018

Staging branch URL: https://upgrade-api-client.pfe-preview.zooniverse.org

Fixes #4179.

Fixes bearer token expiration problems with the Talk client.

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you rm -rf node_modules/ && npm install and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on Travis?

Optional

Fixes bearer token expiration problems with the Talk client.
@simoneduca
Copy link
Contributor

Testing this seems to involve waiting until the token actually expires. Any alternative thoughts?

@eatyourgreens
Copy link
Contributor Author

The steps to replicate on #4179 say "wait a long time…"

@simoneduca
Copy link
Contributor

I was able to reproduce the bug as well as test the fix. LGTM.

@simoneduca simoneduca merged commit fbcce3a into master Jan 24, 2018
@simoneduca simoneduca deleted the upgrade-api-client branch January 24, 2018 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants