-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public project dashboard #2333
Public project dashboard #2333
Conversation
If this is going to add a stats link to the top navigation bar can the padding be reduced between the elements to fit more on in one line. If you've got two external links even with short titles for most reasonable sizes of the browser on my 13inch screen for both of my live projects the navigation bar it barely fits on one line. If I add any more characters to planet four: Terrains site guide link beyond 'Guide' it pushes the blog link to a second row and looks awkward. |
@mschwamb the more I think about it the less I like the idea of putting the link in the top bar. It might be more at home on the project's landing page near the current counters. |
@CKrawczyk FWIW I really like that idea |
@CKrawczyk me too |
c0a387b
to
ea67801
Compare
4d16673
to
bd3f9a6
Compare
d8f53dd
to
09af7c9
Compare
@@ -19,9 +21,12 @@ | |||
"markdownz": "~4.0.2", | |||
"modal-form": "~2.3.0", | |||
"moment": "~2.9.0", | |||
"panoptes-client": "~2.0.0", | |||
"panoptes-client": "git://github.com/CKrawczyk/panoptes-javascript-client.git#add-stats-server", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Panoptes client version should be 2.2 to pick up the stats server config.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is the stats server defined in panoptes-client if it's not used there? Should an interface with the stats server interface be part of panoptes-client?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, forgot to change that back. Thanks @eatyourgreens
@CKrawczyk @brian-c My first pass at a really simple stats client: I've tested it locally by replacing the statsClient
.update
projectId: @props.projectId
workflowId: @props.workflowId
.statCount period, type |
@CKrawczyk here's a PR that removes the Promise Renderers and pulls the stats counts in from the API client. CKrawczyk#2 |
@eatyourgreens I just added in your changes and hooked it up so the dropdown menus fetch the new stats when changed. |
The api calls have been updated to reflect the code changes in zooniverse/panoptes-javascript-client#39. |
Great. I think all that's left now is to update |
Small style change in zooniverse/panoptes-javascript-client@9973917 The API params should be |
panoptes-client 2.3.0 has been published with the stats client. |
OK, changes made. I also pushed latest changes to preview and everything seems to be in order. |
Get rid of the Promise Renderer. Store the stats data in component state.
3b0efc7
to
0e2d86d
Compare
"counterpart": "~0.17.0", | ||
"data-uri-to-blob": "0.0.4", | ||
"debounce": "~1.0.0", | ||
"drag-reorderable": "~0.1.0", | ||
"fast-levenshtein": "~1.0.7", | ||
"history": "~1.17.0", | ||
"json-api-client": "~3.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can go now that we've moved the API call to the Panoptes client.
Excellent. If you can remove |
Do you think I should add a footnote in about the gaps in the stats data explaining that they were caused by a bug in our event stream and not issues with the main site? I get the feeling if this is not included users might mistakenly think classifications were lost. Since the gaps are during known times I can make sure the footnote only shows up if the project was launched before either of the gaps started. |
@eatyourgreens I added in the following footnotes to inform users about the gaps in the stats data (they only show up if the project launched before these gaps happened):
Do these look reasonable? @brian-c I noticed you reverted the version bump of the panoptes client, since this branch is dependent on that version should we hold off merging this until the issues is resolved? |
Yes, please wait, should be fixed again today. |
Looks like this is good to go now. |
This branch is dependent on the configuration of the stats server in this PR: zooniverse/panoptes-javascript-client#29
This adds a public stats page for all PFE projects (will close #2326). It provides stats for each workflow and the number of classifications/talk posts per hour, day, week, or month.
Things left to do:
Note 1: the stats server only collects data for the projects on production, to access this page make sure
?env=production
is in the URL. E.g.http://localhost:3735/projects/zooniverse/pulsar-hunters/stats/?env=production
Note 2: the gap in the classification data from Jan 13 to Feb 7 was due to an error in the stats server, not an issue on the main site.
Note 3: navigating the bar graphs for long running projects when viewed by hour is not the smoothest thing in the world, but I think it is good enough for now.