This repository has been archived by the owner on Feb 16, 2019. It is now read-only.
Multiple mailboxes #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Instead of always polling the inbox of an account you can now specify the mailbox you want to poll
- We encode the message with the errors=ignore option because otherwhise message_from_string could crash when trying to encode with errors=strict
| @@ -17,6 +17,7 @@ | |||
|
|
|||
| import imaplib | |||
| import email, email.utils, email.header | |||
| import codecs | |||
There was a problem hiding this comment.
There's no need to import the codecs module here, since you're not using it. (.encode() and .decode() are string properties)
ghost
assigned 
|
I've merged b50ec4a and added a small change on top of that which ensures INBOX is used as a mailbox when mailbox isn't specified, to ensure people updating the plugin won't have to adjust their config. I don't like the changes from de447f0 though, that isn't right. There's more encoding/decoding mess I need to do properly some time though, so I will get around to that later. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the feature requested in issue #1 and also contains a fix for a bug that caused the mailpoller to crash when the mail couldn't be decoded.