Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing issue 2214 #5

Open
wants to merge 44 commits into
base: main
Choose a base branch
from
Open

testing issue 2214 #5

wants to merge 44 commits into from

Conversation

zondervancalvez
Copy link
Owner

@zondervancalvez zondervancalvez commented Jun 7, 2024

This is a sample PR Description
Testing commit message 06-27 2:20pm
Testing commit message 06-27 3:10pm
Testing commit message 06-27 3:25pm
Testing commit message 06-27 3:29pm
Testing commit message 06-28 2:27pm
Testing commit message 06-28 2:43pm
Testing commit message 06-28 2:55pm na
Testing commit message 06-28 2:07pm
Testing commit message 07-01 2:51pm
Testing commit message 07-01 2:53pm
Testing commit message 07-02 3:32pm
Testing commit message 07-02 3:34pm
Testing commit message 07-02 3:39pm
Testing commit message 07-02 3:55pm
Testing commit message 07-03 2:16pm
Testing commit message 07-03 2:26pm
Testing commit message 07-03 2:29pm
Testing commit message 07-03 2:53pm
Testing commit message 07-03 2:58pm
Testing commit message 07-03 3:01pm
Testing commit message 07-03 3:08pm
Testing commit message 07-03 3:11pm
Testing commit message 07-04 2:35pm

Pull Request Requirements

  • Rebased onto upstream/main branch and squashed into single commit to help maintainers review it more efficient and to avoid spaghetti git commit graphs that obfuscate which commit did exactly what change, when and, why.
  • Have git sign off at the end of commit message to avoid being marked red. You can add -s flag when using git commit command. You may refer to this link for more information.
  • Follow the Commit Linting specification. You may refer to this link for more information.

Character Limit

  • Pull Request Title and Commit Subject must not exceed 72 characters (including spaces and special characters).
  • Commit Message per line must not exceed 80 characters (including spaces and special characters).

A Must Read for Beginners
For rebasing and squashing, here's a must read guide for beginners.

@zondervancalvez zondervancalvez force-pushed the testissue2214 branch 9 times, most recently from b7c5aa3 to 6df2e37 Compare June 18, 2024 07:38
@zondervancalvez zondervancalvez force-pushed the testissue2214 branch 2 times, most recently from a4704d6 to 3dd2163 Compare June 19, 2024 06:29
.github/workflows/ci.yaml Fixed Show fixed Hide fixed
@zondervancalvez zondervancalvez force-pushed the testissue2214 branch 17 times, most recently from d85de5c to 3b5197d Compare June 26, 2024 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant