Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

just testing pylint github annotations #2

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,11 @@ repos:
rev: 5.13.2
hooks:
- id: isort
- repo: https://github.com/pylint-dev/pylint
rev: v3.0.3
- repo: https://github.com/crazybolillo/pylint
rev: 2c76860ce80c5518448abc17dd039952f68bc4d7
hooks:
- id: pylint
args: [--output-format=github]
- repo: https://github.com/pre-commit/mirrors-prettier
rev: v3.1.0
hooks:
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ line-length = 119
line_length = 119

[tool.pylint]
enable = ["useless-suppression"]
enable = ["all"]
disable = ["import-error", "fixme"]
max-line-length = 119

Expand Down
5 changes: 3 additions & 2 deletions src/balba/balba.py
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
dev,
)

echo(f"Using kicad-cli {version}")
echo(f"Using kicad-cli 5")

Check warning on line 36 in src/balba/balba.py

View workflow job for this annotation

GitHub Actions / pre-commit

W1309

Using an f-string that does not have any interpolated variables
echo(f"Looking for projects in {source}")

projects: list[Project] = []
Expand All @@ -46,5 +46,6 @@

echo(f"Generating website in {output}")
builder.build_website(projects)
builder.no_member()

Check failure on line 49 in src/balba/balba.py

View workflow job for this annotation

GitHub Actions / pre-commit

E1101

Instance of 'Builder' has no 'no_member' member

return 0
return 0 #
Loading