Sector Nord AG: Fixed gap caused by async widgets #607
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Currently, asynchronous widgets are not correctly hidden when they don't have content, resulting in gaps between the displayed widgets.
This bug can be exacerbated by installing third-party add-ons that contain asynchronous widgets that are registered but not currently displayed. In this case, the gap will grow with each additional asynchronous widget without content.
This PR addresses the issue by adding a check to hide any widget with empty content after it has been initialized.
Additionally, as an alternative suggestion, using the following CSS rule could also hide empty widget containers more directly:
This issue arises because the flexbox property for
.SidebarColumn
appliesgap: var(--gap-md);
to every element in the column, including those that should be hidden. Consequently, even when a widget is absent, the gap remains, leading to an inconsistent layout. In Znuny 6, a flexbox layout is not used; instead, each element containing the.WidgetAction
class is assigned amargin-bottom: 15px;
. Since the asynchronous widgets without content do not include this class, the issue of unwanted gaps does not appear in Znuny 6.Type of change
1 - 🐞 bug 🐞
Breaking change
This PR does not introduce any breaking changes.
Additional information
To recreate bug:
Checklist