Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sector Nord AG: fixed undefined VoteTime behavior #4

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mbouws
Copy link

@mbouws mbouws commented Nov 14, 2024

Proposed change

This change prevents an error in the daemon task “SurveyRequestsDelete” if the VoteTime is undefined and so prevents notifications to the e-mail address stored in “Daemon::SchedulerTaskWorker::NotificationRecipientEmail”.

  • '1 - 🐞 bug 🐞' - Bugfix (non-breaking change which fixes an issue)

Additional information

Error Message before:
[Thu Nov 14 12:01:00 2024] otrs.Console.pl: Use of uninitialized value $Row[3] in concatenation (.) or string at /opt/otrs/Kernel/System/Console/Command/Maint/Survey/RequestsDelete.pm line 133.
Survey:SurveyTitleExample TicketNumber:200111074 SendTime:2023-11-13 13:06:22 VoteTime: CreateTime:2023-11-13 13:06:22
Survey:SurveyTitleExample TicketNumber:200111078 SendTime:2023-11-13 13:16:37 VoteTime:2023-11-13 13:54:01 CreateTime:2023-11-13 13:16:37

after:
Survey:SurveyTitleExample TicketNumber:200111074 SendTime:2023-11-13 13:06:22 VoteTime: CreateTime:2023-11-13 13:06:22
Survey:SurveyTitleExample TicketNumber:200111078 SendTime:2023-11-13 13:16:37 VoteTime:2023-11-13 13:54:01 CreateTime:2023-11-13 13:16:37

Checklist

  • The code change is tested and works locally.(❗)
  • There is no commented out code in this PR.(❕)
  • You improved or added new unit tests.(❕)
  • Local ZnunyCodePolicy passed.(❕)
  • Local UnitTests / Selenium passed.(❕)
  • GitHub workflow CI (UnitTests / Selenium) passed.(❗)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant