Merge branch 'main' into content_type_fix

core/src/main/kotlin/in/specmatic/core/pattern/BooleanPattern.kt

@@ -24,7 +24,7 @@ data class BooleanPattern(val example: String? = null) : Pattern, ScalarType {
         return listOf(NullPattern)
     }
 
-    override fun parse(value: String, resolver: Resolver): Value = when (value) {
+    override fun parse(value: String, resolver: Resolver): Value = when (value.lowercase()) {
         !in listOf("true", "false") -> throw ContractException(mismatchResult(BooleanPattern(), value, resolver.mismatchMessages).toFailureReport())
         else -> BooleanValue(value.toBoolean())
     }

core/src/test/kotlin/in/specmatic/core/pattern/BooleanPatternTest.kt

@@ -30,4 +30,10 @@ internal class BooleanPatternTest {
             "null"
         )
     }
+
+    @Test
+    fun `should parse a value with capital T or F as boolean` () {
+        assertThat(BooleanPattern().parse("True", Resolver())).isEqualTo(BooleanValue(true))
+        assertThat(BooleanPattern().parse("False", Resolver())).isEqualTo(BooleanValue(false))
+    }
 }

core/src/test/kotlin/in/specmatic/stub/HttpStubTest.kt

@@ -996,7 +996,8 @@ paths:
         fun `should return descriptive error message when there are no valid specifications loaded`() {
             val httpStub = HttpStub(emptyList())
             httpStub.use { stub ->
-                val response = stub.client.execute(HttpRequest("POST", "/data", emptyMap(), parsedJSONObject("""{"id": 10}""")))
+                val response =
+                    stub.client.execute(HttpRequest("POST", "/data", emptyMap(), parsedJSONObject("""{"id": 10}""")))
                 assertThat(response.status).isEqualTo(400)
                 assertThat(response.body).isEqualTo(StringValue("No valid API specifications loaded"))
             }
@@ -1007,7 +1008,8 @@ paths:
     fun `should stub out a path having a space and return a randomised response`() {
         val pathWithSpace = "/da ta"
 
-        val specification = OpenApiSpecification.fromFile("src/test/resources/openapi/spec_with_space_in_path.yaml").toFeature()
+        val specification =
+            OpenApiSpecification.fromFile("src/test/resources/openapi/spec_with_space_in_path.yaml").toFeature()
 
         HttpStub(specification).use { stub ->
             val request = HttpRequest("GET", pathWithSpace)
@@ -1091,7 +1093,8 @@ paths:
                             properties:
                               id:
                                 type: integer
-        """.trimIndent(), "").toFeature()
+        """.trimIndent(), ""
+        ).toFeature()
 
         HttpStub(specification).use { stub ->
             val request = HttpRequest("GET", "/data", queryParams = mapOf(queryParamWithSpace to "5"))
@@ -1108,6 +1111,70 @@ paths:
         }
     }
 
+    @Test
+    fun `should stub out a request for boolean query param with capital T or F in the incoming request`() {
+        val specification = createStubFromContracts(listOf("src/test/resources/openapi/spec_with_boolean_query.yaml"))
+
+        specification.use { stub ->
+            val request = HttpRequest("GET", "/data", queryParams = mapOf("enabled" to "True"))
+
+            val response = stub.client.execute(request)
+
+            assertThat(response.status).isEqualTo(200)
+            response.body.let {
+                assertThat(it).isInstanceOf(JSONObjectValue::class.java)
+                it as JSONObjectValue
+
+                assertThat(it.jsonObject["id"]).isInstanceOf(NumberValue::class.java)
+            }
+        }
+    }
+
+    @Test
+    fun `should recognize a request for boolean query param with capital T or F in the incoming request`() {
+        val specification = OpenApiSpecification.fromYAML(
+            """
+            openapi: 3.0.1
+            info:
+              title: Random
+              version: "1"
+            paths:
+              /data:
+                get:
+                  summary: Random
+                  parameters:
+                    - name: enabled
+                      in: query
+                      schema:
+                        type: boolean
+                  responses:
+                    "200":
+                      description: Random
+                      content:
+                        application/json:
+                          schema:
+                            type: object
+                            properties:
+                              id:
+                                type: integer
+        """.trimIndent(), ""
+        ).toFeature()
+
+        HttpStub(specification).use { stub ->
+            val request = HttpRequest("GET", "/data", queryParams = mapOf("enabled" to "True"))
+
+            val response = stub.client.execute(request)
+
+            assertThat(response.status).isEqualTo(200)
+            response.body.let {
+                assertThat(it).isInstanceOf(JSONObjectValue::class.java)
+                it as JSONObjectValue
+
+                assertThat(it.jsonObject["id"]).isInstanceOf(NumberValue::class.java)
+            }
+        }
+    }
+
     @Test
     fun `stub out a spec with no request body and respond to a request which has no body`() {
         val specification = OpenApiSpecification.fromYAML("""

core/src/test/resources/openapi/spec_with_boolean_query.yaml

@@ -0,0 +1,23 @@
+openapi: 3.0.1
+info:
+  title: Random
+  version: "1"
+paths:
+  /data:
+    get:
+      summary: Random
+      parameters:
+        - name: enabled
+          in: query
+          schema:
+            type: boolean
+      responses:
+        "200":
+          description: Random
+          content:
+            application/json:
+              schema:
+                type: object
+                properties:
+                  id:
+                    type: integer

core/src/test/resources/openapi/spec_with_boolean_query_data/stub.json

@@ -0,0 +1,15 @@
+{
+  "http-request": {
+    "method": "GET",
+    "path": "/data",
+    "query": {
+      "enabled": "True"
+    }
+  },
+  "http-response": {
+    "status": 200,
+    "body": {
+      "id": 10
+    }
+  }
+}

version.properties

@@ -1 +1 @@
-version=1.2.4
+version=1.2.6