Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add RGB underglow and backlighting events #2706

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: Add RGB underglow and backlighting events #2706

wants to merge 2 commits into from

Conversation

ReFil
Copy link
Contributor

@ReFil ReFil commented Dec 12, 2024 •
edited
Loading

As a preparation for a respin of #2036 RGB underglow and backlighting need their own state changed events

PR check-list

  • Branch has a clean commit history
  • Additional tests are included, if changing behaviors/core code that is testable.
  • Proper Copyright + License headers added to applicable files (Generally, we stick to "The ZMK Contributors" for copyrights to help avoid churn when files get edited)
  • Pre-commit used to check formatting of files, commit messages, etc.

ReFil added 2 commits December 12, 2024 15:24
@ReFil
feat(backlight): Add backlight state changed event
ca2ea82 
Add a backlight state changed event whenever the backlight is updated
@ReFil
feat(underglow): Add underglow state changed event
b1534ef 
Add event triggered when underglow state is saved
@ReFil ReFil requested a review from a team as a code owner December 12, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lighting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ReFil @caksoylar