Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(boards): add nrf52 nosd snippets #2545

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

krikun98
Copy link
Contributor

@krikun98 krikun98 commented Oct 9, 2024

Add snippet to build for nRF52833/52840 boards while ignoring the SoftDevice. This is necessary as nRF52833 boards are memory-constrained and nRF52840 boards can accidentally erase the SoftDevice.

Board/Shield Check-list

  • This board/shield is tested working on real hardware
  • General consistent formatting of DeviceTree files

@krikun98 krikun98 requested a review from a team as a code owner October 9, 2024 23:24
@krikun98
Copy link
Contributor Author

krikun98 commented Oct 9, 2024

Tested on a Jorne with an nRF52833 nrfmicro.

@krikun98 krikun98 requested a review from a team as a code owner October 10, 2024 00:37
@krikun98 krikun98 force-pushed the nrf52833-nosd-snippet branch 3 times, most recently from 54541d9 to 6a3f9ea Compare October 10, 2024 00:53
Copy link
Contributor

@caksoylar caksoylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we added a snippets section, it'd be nice to document zmk-usb-logging and studio-rpc-usb-uart as well. But it's fine to not do that in this PR.

docs/docs/config/system.md Outdated Show resolved Hide resolved
docs/docs/config/system.md Outdated Show resolved Hide resolved
docs/docs/config/system.md Outdated Show resolved Hide resolved
docs/docs/config/system.md Outdated Show resolved Hide resolved
docs/docs/config/system.md Outdated Show resolved Hide resolved
docs/docs/config/system.md Outdated Show resolved Hide resolved
docs/docs/config/system.md Outdated Show resolved Hide resolved
docs/docs/config/system.md Outdated Show resolved Hide resolved
docs/docs/config/system.md Outdated Show resolved Hide resolved
@krikun98 krikun98 force-pushed the nrf52833-nosd-snippet branch 2 times, most recently from 5708f26 to caa1368 Compare October 10, 2024 09:14
@krikun98
Copy link
Contributor Author

@caksoylar, @Nick-Munnich, I added nrf52840-nosd to the documentation, could you please take another look?

docs/docs/config/system.md Outdated Show resolved Hide resolved
docs/docs/config/system.md Outdated Show resolved Hide resolved
docs/docs/config/system.md Show resolved Hide resolved
@krikun98 krikun98 changed the title feat(boards): add nrf52833-nosd snippet feat(boards): add nrf52 nosd snippets Oct 13, 2024
Add snippet to build for nRF52833 boards while ignoring the SoftDevice.
This is necessary as those boards are memory-constrained.
Add snippet to build for nRF52840 boards while ignoring the SoftDevice.
This might be useful for especially memory-intensive applications.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants