feat(docs): Add a split keyboards feature page #2406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caksoylar
commented
Aug 5, 2024
caksoylar
force-pushed
the
docs/split-feature
branch
from
f0c0dbe to
bdd2e92
Compare
Nick-Munnich
reviewed
Aug 5, 2024
There was a problem hiding this comment.
LGTM overall, just some minor touchups where I think things could be phrased differently or be made more precise. Feel free to discard most of them if you don't agree with them. There were some parts where I didn't make phrasing suggestions because I thought they might change due to other comments, so I left them for later.
caksoylar
commented
Aug 5, 2024
caksoylar
force-pushed
the
docs/split-feature
branch
from
826e23a to
09524b9
Compare
Nick-Munnich
reviewed
Aug 6, 2024
caksoylar
force-pushed
the
docs/split-feature
branch
from
cc0990a to
3567978
Compare
Nick-Munnich
approved these changes
Aug 7, 2024
|
Oh, just remembered a point: Another note on the battery lives of the central and peripherals would be good somewhere. |
You are right, I'll add a note for that as well, under central/peripheral roles section. |
Nick-Munnich
reviewed
Aug 7, 2024
|
Also a note that this closes #550 as obsolete. |
caksoylar
force-pushed
the
docs/split-feature
branch
from
99d4e66 to
57bef5e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an explainer page to describe how split keyboards work in ZMK, with specific details on flashing, pairing, split communications and behaviors with locality. Fixes #948.