feat(ble): Add option to disable profile auto save #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huber-th
force-pushed
the
ble-persist-profile-change-config
branch
from
503b80d to
6fa0063
Compare
|
LGTM on docs (also sounds like a good improvement). |
caksoylar
reviewed
Apr 25, 2024
huber-th
force-pushed
the
ble-persist-profile-change-config
branch
from
6fa0063 to
a26dc72
Compare
huber-th
force-pushed
the
ble-persist-profile-change-config
branch
2 times, most recently
from
5673815 to
9dc7694
Compare
|
Rebase from |
huber-th
force-pushed
the
ble-persist-profile-change-config
branch
from
9dc7694 to
4497b01
Compare
huber-th
force-pushed
the
ble-persist-profile-change-config
branch
from
4497b01 to
7eb1879
Compare
Add Kconfig option to disable persisting the BLE profile index after every change. This is useful if the user wants to have the same profile connected at startup regardless of which profile was connected last. Add `&bt BT_SAVE` command to manually persist the currently active BLE profile, ensuring it is selected as the active profile on startup.
huber-th
force-pushed
the
ble-persist-profile-change-config
branch
from
7eb1879 to
ef36b19
Compare
|
@petejohanson, I wanted to check in on the status of this PR. Is this something that you would consider for merging, or would you prefer to close it? I might be an outlier in wanting this behavior on my keyboard, but I'm happy to hear your thoughts. Please let me know if any changes are needed on my end. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Kconfig option
ZMK_BLE_PERSIST_PROFILE_ON_CHANGEwith default set toy, to allow users to disable persisting the BLE profile index after every change. This is useful if the user wants to have the same profile connected at startup regardless of which profile was connected last.Add
&bt BT_SAVEcommand to manually persist the currently active BLE profile, ensuring it is selected as the active profile on startup.