feat(docs): Document locality for global and source-specific behaviors #1124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caksoylar
force-pushed
the
docs-locality
branch
from
8d7f951
to
0268b77
Compare
dxmh
approved these changes
Feb 7, 2022
There was a problem hiding this comment.
These additions look good to me. Nice and clear. I think having the note along side each behaviour is helpful. 👍
Would be good to get a quick approval from @petejohanson (as the author of #547), just to confirm everything is technically correct.
petejohanson
approved these changes
Feb 7, 2022
|
Oh, @dxmh already approved. Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add documentation to denote how global and source-specific (should we call it source-local?) behaviors affect split keyboards. Most useful is likely the one for reset behaviors, since global behaviors are usually expected to work that way.