Skip to content

Commit

Permalink
Fix absolute paths on eject (facebook#5214)
Browse files Browse the repository at this point in the history
  • Loading branch information
gaearon authored Oct 1, 2018
1 parent 4abbe95 commit 6d744dd
Showing 1 changed file with 14 additions and 2 deletions.
16 changes: 14 additions & 2 deletions scripts/utils/createJestConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,20 @@ module.exports = (resolve, rootDir, isEjecting) => {
// in Jest configs. We need help from somebody with Windows to determine this.
const config = {
collectCoverageFrom: ['src/**/*.{js,jsx}'],
resolver: require.resolve('jest-pnp-resolver'),
setupFiles: [require.resolve('react-app-polyfill/jsdom')],

// TODO: this breaks Yarn PnP on eject.
// But we can't simply emit this because it'll be an absolute path.
// The proper fix is to write jest.config.js on eject instead of a package.json key.
// Then these can always stay as require.resolve()s.
resolver: isEjecting
? 'jest-pnp-resolver'
: require.resolve('jest-pnp-resolver'),
setupFiles: [
isEjecting
? 'react-app-polyfill/jsdom'
: require.resolve('react-app-polyfill/jsdom'),
],

setupTestFrameworkScriptFile: setupTestsFile,
testMatch: [
'<rootDir>/src/**/__tests__/**/*.{js,jsx}',
Expand Down

0 comments on commit 6d744dd

Please sign in to comment.