Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outgoing proxy support #45

Closed
ConanMalone opened this issue Mar 29, 2017 · 5 comments
Closed

outgoing proxy support #45

ConanMalone opened this issue Mar 29, 2017 · 5 comments

Comments

@ConanMalone
Copy link

Hi, we've got lua-resty-openidc working, and are now trying to get it to work in an environment that requires all traffic to go through an outbound proxy. We are getting a connection refused error when trying to access the discovery URL. We have installed the lua-resty-socket module but we're amateurs at lua. Could you point us in the right direction to get openidc to use a proxy?

@zandbelt
Copy link
Contributor

I would have liked to point you to the support for that in the underlying lua-resty-http module that lua-resty-openidc uses to make such calls. But apparently that support does not exist there, see: ledgetech/lua-resty-http#63

So it would require modifications to lua-resty-openidc (or preferably lua-resty-http...) to make this work. Making this an enhancement request

@zandbelt zandbelt changed the title proxy support for openidc outgoing proxy support Mar 29, 2017
@zandbelt
Copy link
Contributor

zandbelt commented Aug 1, 2017

@grrolland
Copy link
Contributor

Hello,

I create a pull request to fix this issue. Let me know if this could be merged with the master branche.

Regards.

@zandbelt
Copy link
Contributor

Nice work! Does it require a particular version of lua-resty-http?

@grrolland
Copy link
Contributor

Yes, this patch require the version 0.11 of lua-resty-http.

grrolland added a commit to grrolland/lua-resty-openidc that referenced this issue Jan 30, 2018
* Naïve implementation works with OpendId Connect Authorization
  Code Flow

* Add proxy_opts table to the opts, with two values :
   - http_proxy (in curl format : http://<proxy_host>:<proxy_port>/)
   - https_proxy (in curl format : http://<proxy_host>:<proxy_port>/)
grrolland added a commit to grrolland/lua-resty-openidc that referenced this issue Jan 30, 2018
* Add proxy configuration on userinfo endpoint
zandbelt added a commit that referenced this issue Jan 30, 2018
Fix #45 : Add outgoing proxy support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants