Limit scope for cn checking in SAN #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6c23670.
util: gtld_map autopull updates for 2021-10-21T07:25:20 UTC
vanbroup
reviewed
Apr 5, 2024
| for _, commonName := range name.CommonNames { | ||
| if util.IsMailboxAddress(commonName) { | ||
| mailboxAddresses = append(mailboxAddresses, commonName) | ||
| if includeCN { |
There was a problem hiding this comment.
Suggested change
| if includeCN { | |
| if len(name.EmailAddress) == 0 { |
This would cover more scenario's and doesn't require additional function parameters.
There was a problem hiding this comment.
would not that, probably very unlikely, produce some false positives? E.g. for a sponsor-validated certificate with a subjectDN featuring a CN which has a pseudonym with a @ character and no emailAddress RDN in subject.
There was a problem hiding this comment.
That might be possible indeed.
|
Agreed |
christopher-henderson
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses issues of discussion in PR #809