Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert all Lint to CertificateLint #766

Closed
wants to merge 2 commits into from
Closed

Conversation

aaomidi
Copy link
Contributor

@aaomidi aaomidi commented Nov 11, 2023

Solves #765

Generation code: https://github.com/aaomidi/zlint-migration

The formatting isn't...what I exactly wanted it to be. I'm still trying to see if I can go directly to a well formatted struct and not have to run gofmpt on everything.

I've asked about the formatting issue: https://groups.google.com/g/golang-nuts/c/C16T4H7slA4

@aaomidi
Copy link
Contributor Author

aaomidi commented Nov 12, 2023

@zakird, I'm curious since you're a major maintainer here. Would you accept the formatting of the RegisterCertificateLint methods as is, or should I try to spend some more time getting the formatting just right?

Also just curious, how do you feel about the fact that I ended up running gofumpt on all of these lints?

@aaomidi
Copy link
Contributor Author

aaomidi commented Nov 12, 2023

Well, I actually think I have a correct solution in #767 now

@aaomidi aaomidi closed this Nov 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant