Custom static analysis tooling for CI/CD

[christopher-henderson]

I'm still working on seeing if it works with CI/CD, plus it needs more code docs, but this is the general idea.

At the very least it has found several lints that we missed from #536 !

Found 2 linting errors
--------------------
Linting Error

Got the wrong method signature as the first function declaration within the linter.
ZLint lints must have func init() { ... } as their first function declaration

File ../../lints/cabf_br/lint_cab_dv_conflicts_with_locality.go, line 28

func (l *certPolicyConflictsWithLocality) Initialize() error {
	return nil
}

For more information, please see the following citations.
	https://github.com/zmap/zlint/issues/371
	https://golang.org/doc/effective_go.html#init

--------------------
Linting Error

Got the wrong method signature as the first function declaration within the linter.
ZLint lints must have func init() { ... } as their first function declaration

File ../../lints/rfc/lint_subject_printable_string_badalpha.go, line 39

func validatePrintableString(rawPS []byte) error {
	if !printableStringRegex.Match(rawPS) {
		return errors.New("encoded PrintableString contained illegal characters")
	}
	return nil
}

For more information, please see the following citations.
	https://github.com/zmap/zlint/issues/371
	https://golang.org/doc/effective_go.html#init

This addresses issue #546

[sleevi]

Deferring this to the real go users, so just one inline comment from mucking about with GitHub's CI tooling ;)

[cpu]

Haven't forgotten about reviewing this branch. I'll get to it this week 🤞

[cpu]

Thank you for taking this @christopher-henderson. It's a really cool piece of work. I haven't worked with the Go AST before and I'm impressed that you got something workable up and running so quickly.

I left a lot of comments but most of them are very small nits. The core of the work seems great 🚀

[cpu]

At the very least it has found several lints that we missed from #536 !

Also: that rules! Nice work. It's gratifying to see having this as part of CI will definitely result in greater consistency.

[christopher-henderson]

Hey, the linter successfully failed! Reckon I should fix those while we're here.

[christopher-henderson]

I haven't worked with the Go AST before and I'm impressed that you got something workable up and running so quickly.

😊 I admit it's not my first rodeo with the Go compiler. I actually forked it (GoSearch) for my grad school research in order to make a dialect of Go that supported a backtracking engine at runtime.

[cpu]

I admit it's not my first rodeo with the Go compiler. I actually forked it (GoSearch) for my grad school research in order to make a dialect of Go that supported a backtracking engine at runtime.

@christopher-henderson That's very cool :-) Thanks for sharing.

Is this branch ready for me to review again or do you need more time to land changes for the feedback?

[christopher-henderson]

@cpu I believe it should be GTG now.

[cpu]

Thanks @christopher-henderson, I mostly flagged typos in the new docstrings this pass. If you can fix those and the other couple things I commented on I think this is ready to be stamped/merged.

[cpu]

Thanks @christopher-henderson