remove forEach from majority of DOM collection prototypes
#987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These appear to be added to address zloirock#329. However, only NodeList and DOMTokenList are documented and tested to have forEach on their prototypes.
moorejs
changed the title
{forEach, keys, values, entries } from majority of DOM collection prototypesforEach from majority of DOM collection prototypes
This was referenced Oct 19, 2021
|
Why not remove it from 4.x.x？ |
|
The comment above explains why. Because it's a bug, it's missed in any spec or proposal, it's not documented, more other - code comments say that it should not be here, because the additional time of its availability could cause new cases of incorrect usage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #988.
An alternative to this PR is to expand the compatibility test to include all the DOM Iterables.
I wasn't sure how you would want this change, so I have an simpler implementation here.