Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3.9.0+ breaks on node v0.12 #933

Closed
ljharb opened this issue May 5, 2021 · 5 comments
Closed

v3.9.0+ breaks on node v0.12 #933

ljharb opened this issue May 5, 2021 · 5 comments

Comments

@ljharb
Copy link

ljharb commented May 5, 2021

require('core-js') breaks in node v0.12 with:

TypeError: Cannot convert a Symbol value to a string
    at String (native)
    at Object.<anonymous> ($PWD/node_modules/core-js/modules/es.symbol.description.js:34:23)

This works fine in v3.8.3, and breaks in v3.9.0. Looking at v3.8.3...v3.9.0, but nothing jumps out.

@zloirock
Copy link
Owner

zloirock commented May 5, 2021

Interesting, thanks, I'll check it tomorrow.

@zloirock
Copy link
Owner

zloirock commented May 5, 2021

Are you sure that it's introduced not in 3.9.1? It could be caused by 2394dac .

@ljharb
Copy link
Author

ljharb commented May 6, 2021

I’m not certain; i installed a lot of versions to try to isolate it. That commit does seem the likely cause.

@zloirock
Copy link
Owner

zloirock commented May 6, 2021

Thanks, seems at the time of this PR I forgot about old V8 versions shema. I'll publish it after testing.

ljharb added a commit to inspect-js/is-equal that referenced this issue May 6, 2021
ljharb added a commit to inspect-js/is-generator-function that referenced this issue May 6, 2021
@zloirock
Copy link
Owner

zloirock commented May 6, 2021

Fixed in 3.12.0.

ljharb added a commit to inspect-js/is-generator-function that referenced this issue May 6, 2021
ljharb added a commit to inspect-js/is-equal that referenced this issue May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants