Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise polyfill overriding problem #332

Closed
slawwan opened this issue Aug 24, 2017 · 2 comments
Closed

Promise polyfill overriding problem #332

slawwan opened this issue Aug 24, 2017 · 2 comments

Comments

@slawwan
Copy link

slawwan commented Aug 24, 2017

I have unexpected for me behavior in Firefox 55.0.2 64bit
image

I've found similar issue #264 and explanations in #191 and I saw other issues and discussions
So it is a problem not only for me

I understand that main aim of overriding existing Promise is to fix its bugs.
But there is a problem if some code, in my example native code, works with native Promise
So when I work with fetch, all chain of then it is a chain of native Promise, not overridden, and it is produce other bugs and problems and it is not obvious. It means that polyfill does not fix problems of native implementation.

Maybe this functionality should be optional?
Or it may be better to abandon this functionality?

@zloirock
Copy link
Owner

It's a duplicate of #178, see my answer: #178 (comment)

@zloirock
Copy link
Owner

Seems you propose something like #283, so I'll close it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants