update String#leftPad with proposal: string filler truncated from t…

…he right side tc39/proposal-string-pad-start-end#6
zloirock · Sep 26, 2015 · 7b15772 · 7b15772
1 parent 6dad33d
commit 7b15772
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 8 deletions.
diff --git a/library/modules/$.string-pad.js b/library/modules/$.string-pad.js
@@ -12,8 +12,6 @@ module.exports = function(that, maxLength, fillString, left){
   if(fillStr == '')fillStr = ' ';
   var fillLen = intMaxLength - stringLength
     , stringFiller = repeat.call(fillStr, Math.ceil(fillLen / fillStr.length));
-  if(stringFiller.length > fillLen)stringFiller = left
-    ? stringFiller.slice(stringFiller.length - fillLen)
-    : stringFiller.slice(0, fillLen);
+  if(stringFiller.length > fillLen)stringFiller = stringFiller.slice(0, fillLen);
   return left ? stringFiller + S : S + stringFiller;
 };
diff --git a/modules/$.string-pad.js b/modules/$.string-pad.js
@@ -12,8 +12,6 @@ module.exports = function(that, maxLength, fillString, left){
   if(fillStr == '')fillStr = ' ';
   var fillLen = intMaxLength - stringLength
     , stringFiller = repeat.call(fillStr, Math.ceil(fillLen / fillStr.length));
-  if(stringFiller.length > fillLen)stringFiller = left
-    ? stringFiller.slice(stringFiller.length - fillLen)
-    : stringFiller.slice(0, fillLen);
+  if(stringFiller.length > fillLen)stringFiller = stringFiller.slice(0, fillLen);
   return left ? stringFiller + S : S + stringFiller;
 };
diff --git a/tests/library/es7.string.pad-left.ls b/tests/library/es7.string.pad-left.ls
@@ -6,7 +6,7 @@ test 'String#padLeft' (assert)->
   {padLeft} = core.String
   assert.ok typeof! padLeft is \Function, 'is function'
   assert.strictEqual padLeft(\abc 5), '  abc'
-  assert.strictEqual padLeft(\abc 4 \de), \eabc
+  assert.strictEqual padLeft(\abc 4 \de), \dabc
   assert.strictEqual padLeft(\abc),  \abc
   assert.strictEqual padLeft(\abc 5 '_'), '__abc'
   assert.strictEqual padLeft('' 0), ''

diff --git a/tests/tests/es7.string.pad-left.ls b/tests/tests/es7.string.pad-left.ls
@@ -8,7 +8,7 @@ test 'String#padLeft' (assert)->
   assert.ok /native code/.test(String::padLeft), 'looks like native'
   assert.strictEqual String::padLeft.name, \padLeft, 'name is "padLeft"'
   assert.strictEqual 'abc'padLeft(5), '  abc'
-  assert.strictEqual 'abc'padLeft(4 \de), \eabc
+  assert.strictEqual 'abc'padLeft(4 \de), \dabc
   assert.strictEqual 'abc'padLeft!,  \abc
   assert.strictEqual 'abc'padLeft(5 '_'), '__abc'
   assert.strictEqual ''padLeft(0), ''