Skip to content

Commit

Permalink
remove TODO
Browse files Browse the repository at this point in the history
  • Loading branch information
bing committed Jun 10, 2024
1 parent a0cca5f commit cfb3808
Showing 1 changed file with 1 addition and 9 deletions.
10 changes: 1 addition & 9 deletions src/parser/types.rs
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,6 @@ pub struct Ty {
}

/// The module preceding structs, functions, or variables.
// TODO: Hash should probably be implemented manually, right now two alias might have different span and so this will give different hashes
#[derive(Default, Debug, Clone, Serialize, Deserialize, Hash, PartialEq, Eq)]
pub enum ModulePath {
#[default]
Expand Down Expand Up @@ -393,7 +392,7 @@ impl FnSig {
}

/// Any kind of text that can represent a type, a variable, a function name, etc.
#[derive(Debug, Default, Clone, Eq, Serialize, Deserialize)]
#[derive(Debug, Default, Clone, Eq, Hash, Serialize, Deserialize)]
pub struct Ident {
pub value: String,
pub span: Span,
Expand All @@ -405,13 +404,6 @@ impl PartialEq for Ident {
}
}

impl Hash for Ident {
fn hash<H: Hasher>(&self, state: &mut H) {
self.value.hash(state);
self.span.hash(state);
}
}

impl Ident {
pub fn new(value: String, span: Span) -> Self {
Self { value, span }
Expand Down

0 comments on commit cfb3808

Please sign in to comment.