Use ff crate for traits and impls #90

str4d · 2018-07-02T06:12:22Z

Depends on zkcrypto/ff#1 and zkcrypto/ff#5

ebfull · 2018-07-02T14:44:56Z

ff has been updated to 0.3.0.

ebfull · 2018-07-02T14:47:33Z

Cargo.toml

+[dependencies.ff]
+git = "https://github.com/str4d/ff"
+rev = "91a8dc8284a09c456b36da44ca7de36f8b50550d"
+
 [features]


Let's change u128-support feature in here to u128-support = ["ff/u128-support"] until we've removed u128-support from ff.

ebfull · 2018-07-02T14:49:40Z

Add yourself to Cargo.toml::authors because I have a feeling this isn't the last PR you're submitting!

str4d · 2018-07-02T14:52:19Z

Comments addressed

ebfull

ACK modulo nit.

ebfull · 2018-07-02T14:54:55Z

src/bls12_381/fq.rs

-    0xef148d1ea0f4c069,
-    0x40ab3263eff0206,
-]);
+use {Field, PrimeField, PrimeFieldDecodingError, PrimeFieldRepr};


use ff::{

ebfull · 2018-07-02T15:06:34Z

@bmerge try

bmerge · 2018-07-02T15:06:41Z

⌛ Trying commit c49590b with merge c123b19...

Use ff crate for traits and impls Depends on zkcrypto/ff#1

bmerge · 2018-07-02T15:31:55Z

💔 Test failed - pairing-linux64-try

ebfull · 2018-07-02T15:38:19Z

Updated CI to nightly-2018-06-28.

@bmerge retry

bmerge · 2018-07-02T15:38:25Z

⌛ Trying commit c49590b with merge 2e1885d...

Use ff crate for traits and impls Depends on zkcrypto/ff#1

bmerge · 2018-07-02T16:02:40Z

💔 Test failed - pairing-linux64-try

ebfull · 2018-07-02T18:38:18Z

@bmerge try

bmerge · 2018-07-02T18:38:24Z

⌛ Trying commit 0954836 with merge 69a88a6...

Use ff crate for traits and impls Depends on zkcrypto/ff#1

bmerge · 2018-07-02T19:04:24Z

💔 Test failed - pairing-linux64-try

ebfull · 2018-07-03T20:27:23Z

@bmerge retry

ebfull · 2018-07-03T20:39:42Z

@bmerge try

Use ff crate for traits and impls Depends on zkcrypto/ff#1 and zkcrypto/ff#5

bmerge · 2018-07-04T19:13:34Z

💔 Test failed - pairing-linux64-try

ebfull · 2018-07-04T19:27:13Z

@bmerge try

bmerge · 2018-07-04T19:27:19Z

⌛ Trying commit 977bdbf with merge 2352eb4...

Use ff crate for traits and impls Depends on zkcrypto/ff#1 and zkcrypto/ff#5

bmerge · 2018-07-04T19:48:23Z

💔 Test failed - pairing-linux64-try

ebfull · 2018-07-04T20:47:15Z

@bmerge try

bmerge · 2018-07-04T20:47:21Z

⌛ Trying commit b140f61 with merge 13799c7...

Use ff crate for traits and impls Depends on zkcrypto/ff#1 and zkcrypto/ff#5

bmerge · 2018-07-04T21:10:05Z

☀️ Test successful - pairing-linux32-try, pairing-linux64-try, pairing-windows32msvc-try, pairing-windows64msvc-try
State: approved= try=True

str4d · 2018-07-04T21:37:53Z

Squashed a couple of the later commits together.

ebfull · 2018-07-04T22:13:34Z

@bmerge try

bmerge · 2018-07-04T22:13:40Z

⌛ Trying commit fa81037 with merge df50d7d...

Use ff crate for traits and impls Depends on zkcrypto/ff#1 and zkcrypto/ff#5

bmerge · 2018-07-04T22:34:47Z

☀️ Test successful - pairing-linux32-try, pairing-linux64-try, pairing-windows32msvc-try, pairing-windows64msvc-try
State: approved= try=True

daira

ACK

ebfull · 2018-07-05T17:26:04Z

@bmerge r+

bmerge · 2018-07-05T17:26:04Z

📌 Commit fa81037 has been approved by ebfull

bmerge · 2018-07-05T17:26:11Z

⌛ Testing commit fa81037 with merge 183a64b...

Use ff crate for traits and impls Depends on zkcrypto/ff#1 and zkcrypto/ff#5

bmerge · 2018-07-05T17:48:06Z

☀️ Test successful - pairing-linux32-auto, pairing-linux64-auto, pairing-windows32msvc-auto, pairing-windows64msvc-auto
Approved by: ebfull
Pushing 183a64b to master...

Make some methods pub for use in External Wallet Generators The exposed APIs may change in future crate versions.

str4d force-pushed the ff branch from 2a34375 to 5762dd8 Compare July 2, 2018 09:06

str4d added 3 commits July 2, 2018 15:47

Use ff crate for Field traits

1db099f

Use explicit imports instead of re-exporting the ff crate

d9d711e

Replace implementations of Fq and Fr with derives

a9d8079

ebfull requested changes Jul 2, 2018

View reviewed changes

str4d force-pushed the ff branch from 5762dd8 to a9d8079 Compare July 2, 2018 14:48

str4d added 2 commits July 2, 2018 15:49

Connect ff u128-support to pairing u128-support

defdf8d

Update authors

bb22a16

ebfull approved these changes Jul 2, 2018

View reviewed changes

Change all remaining uses of *Field to reference ff crate

c49590b

bmerge added a commit that referenced this pull request Jul 2, 2018

Auto merge of #90 - str4d:ff, r=<try>

c123b19

Use ff crate for traits and impls Depends on zkcrypto/ff#1

bmerge added a commit that referenced this pull request Jul 2, 2018

Auto merge of #90 - str4d:ff, r=<try>

2e1885d

Use ff crate for traits and impls Depends on zkcrypto/ff#1

str4d mentioned this pull request Jul 2, 2018

Make pairing and groth16 optional 🎉 zkcrypto/bellman#25

Closed

Add missing SqrtField import to benches

06a1527

bmerge added a commit that referenced this pull request Jul 2, 2018

Auto merge of #90 - str4d:ff, r=<try>

69a88a6

Use ff crate for traits and impls Depends on zkcrypto/ff#1

ebfull mentioned this pull request Jul 3, 2018

Add serde feature. #87

Closed

bmerge added a commit that referenced this pull request Jul 4, 2018

Auto merge of #90 - str4d:ff, r=<try>

ffb636e

Use ff crate for traits and impls Depends on zkcrypto/ff#1 and zkcrypto/ff#5

bmerge added a commit that referenced this pull request Jul 4, 2018

Auto merge of #90 - str4d:ff, r=<try>

2352eb4

Use ff crate for traits and impls Depends on zkcrypto/ff#1 and zkcrypto/ff#5

bmerge added a commit that referenced this pull request Jul 4, 2018

Auto merge of #90 - str4d:ff, r=<try>

13799c7

Use ff crate for traits and impls Depends on zkcrypto/ff#1 and zkcrypto/ff#5

ebfull and others added 4 commits July 4, 2018 22:33

Start using cargo-clippy for CI.

cc5b835

Remove clippy from dependencies.

4752a91

Migrate to ff 0.4

c5b883f

cargo fmt

fa81037

str4d force-pushed the ff branch from b140f61 to fa81037 Compare July 4, 2018 21:37

bmerge added a commit that referenced this pull request Jul 4, 2018

Auto merge of #90 - str4d:ff, r=<try>

df50d7d

Use ff crate for traits and impls Depends on zkcrypto/ff#1 and zkcrypto/ff#5

ebfull approved these changes Jul 5, 2018

View reviewed changes

daira approved these changes Jul 5, 2018

View reviewed changes

bmerge added a commit that referenced this pull request Jul 5, 2018

Auto merge of #90 - str4d:ff, r=ebfull

183a64b

Use ff crate for traits and impls Depends on zkcrypto/ff#1 and zkcrypto/ff#5

bmerge merged commit fa81037 into zkcrypto:master Jul 5, 2018

str4d deleted the ff branch July 5, 2018 18:33

str4d added a commit that referenced this pull request Aug 25, 2020

Merge pull request #90 from adityapk00/paperwallet

5a48d17

Make some methods pub for use in External Wallet Generators The exposed APIs may change in future crate versions.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use ff crate for traits and impls #90

Use ff crate for traits and impls #90

str4d commented Jul 2, 2018 •

edited

Loading

ebfull commented Jul 2, 2018

ebfull Jul 2, 2018

ebfull commented Jul 2, 2018

str4d commented Jul 2, 2018

ebfull left a comment

ebfull Jul 2, 2018

ebfull commented Jul 2, 2018

bmerge commented Jul 2, 2018

bmerge commented Jul 2, 2018

ebfull commented Jul 2, 2018

bmerge commented Jul 2, 2018

bmerge commented Jul 2, 2018

ebfull commented Jul 2, 2018

bmerge commented Jul 2, 2018

bmerge commented Jul 2, 2018

ebfull commented Jul 3, 2018

ebfull commented Jul 3, 2018

bmerge commented Jul 4, 2018

ebfull commented Jul 4, 2018

bmerge commented Jul 4, 2018

bmerge commented Jul 4, 2018

ebfull commented Jul 4, 2018

bmerge commented Jul 4, 2018

bmerge commented Jul 4, 2018

str4d commented Jul 4, 2018

ebfull commented Jul 4, 2018

bmerge commented Jul 4, 2018

bmerge commented Jul 4, 2018

daira left a comment

ebfull commented Jul 5, 2018

bmerge commented Jul 5, 2018

bmerge commented Jul 5, 2018

bmerge commented Jul 5, 2018

Use ff crate for traits and impls #90

Use ff crate for traits and impls #90

Conversation

str4d commented Jul 2, 2018 • edited Loading

ebfull commented Jul 2, 2018

ebfull Jul 2, 2018

Choose a reason for hiding this comment

ebfull commented Jul 2, 2018

str4d commented Jul 2, 2018

ebfull left a comment

Choose a reason for hiding this comment

ebfull Jul 2, 2018

Choose a reason for hiding this comment

ebfull commented Jul 2, 2018

bmerge commented Jul 2, 2018

bmerge commented Jul 2, 2018

ebfull commented Jul 2, 2018

bmerge commented Jul 2, 2018

bmerge commented Jul 2, 2018

ebfull commented Jul 2, 2018

bmerge commented Jul 2, 2018

bmerge commented Jul 2, 2018

ebfull commented Jul 3, 2018

ebfull commented Jul 3, 2018

bmerge commented Jul 4, 2018

ebfull commented Jul 4, 2018

bmerge commented Jul 4, 2018

bmerge commented Jul 4, 2018

ebfull commented Jul 4, 2018

bmerge commented Jul 4, 2018

bmerge commented Jul 4, 2018

str4d commented Jul 4, 2018

ebfull commented Jul 4, 2018

bmerge commented Jul 4, 2018

bmerge commented Jul 4, 2018

daira left a comment

Choose a reason for hiding this comment

ebfull commented Jul 5, 2018

bmerge commented Jul 5, 2018

bmerge commented Jul 5, 2018

bmerge commented Jul 5, 2018

str4d commented Jul 2, 2018 •

edited

Loading