Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider upgrading the rand crate to a version >= 0.5 #105

Closed
Tracked by #1050
huitseeker opened this issue Aug 15, 2019 · 3 comments
Closed
Tracked by #1050

Consider upgrading the rand crate to a version >= 0.5 #105

huitseeker opened this issue Aug 15, 2019 · 3 comments
Milestone
0.15

Comments

@huitseeker
Copy link

The rand crate hereby used is 0.4, while the latest is is now 0.7 and most downstream Rust projects are upgraded to 0.6.x. Specifically the Rand trait is deprecated.

See also zcash/librustzcash#60 and the Upgrade guide
@burdges
Copy link

burdges commented Aug 18, 2019 •
edited
Loading

Appears done in zcash/librustzcash#60

I think https://github.com/filecoin-project/pairing might accept a pull request for a similar upgrade

@str4d
Copy link
Member

str4d commented Sep 23, 2019

We will be upstreaming our changes from https://github.com/zcash/librustzcash shortly.

@huitseeker huitseeker mentioned this issue Sep 24, 2019
Open
66 tasks
@str4d str4d added this to the 0.15 milestone Nov 10, 2019
@str4d
Copy link
Member

str4d commented Nov 10, 2019

This has been done.

@str4d str4d closed this as completed Nov 10, 2019
str4d pushed a commit that referenced this issue Aug 25, 2020
@ebfull
Merge pull request #105 from Eirik0/cargo-clean-up
6f0080b 
cargo fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.15
Development

No branches or pull requests
3 participants
@huitseeker @burdges @str4d