You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using the current crate with the 0.10 version of sha2 turns out to be a little messy:
error[E0277]: the trait bound `CoreWrapper<CtVariableCoreWrapper<Sha512VarCore, UInt<UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>, B0>>>: digest::Update` is not satisfied
--> src/user.rs:84:9
|
84 | RistrettoPoint::hash_from_bytes::<Sha512>(&input)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the trait `digest::Update` is not implemented for `CoreWrapper<CtVariableCoreWrapper<Sha512VarCore, UInt<UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>, B0>>>`
|
= note: required because of the requirements on the impl of `digest::digest::Digest` for `CoreWrapper<CtVariableCoreWrapper<Sha512VarCore, UInt<UInt<UInt<UInt<UInt<UInt<UInt<UTerm, B1>, B0>, B0>, B0>, B0>, B0>, B0>>>`
note: required by a bound in `RistrettoPoint::hash_from_bytes`
--> .../curve25519-dalek-ng-4.1.1/src/ristretto.rs:689:18
|
689 | where D: Digest<OutputSize = U64> + Default
| ^^^^^^^^^^^^^^^^^^^^^^^^ required by this bound in `RistrettoPoint::hash_from_bytes`
It seems like the requirements from this crate are modest, but the change would be quite disruptive (for the same reason) and it might need a version bump. I'd have said a minor release is in order, but you seem to be using major versions for similar changes.
The text was updated successfully, but these errors were encountered:
martinthomson
added a commit
to martinthomson/curve25519-dalek-ng
that referenced
this issue
Jan 27, 2022
Looking forward to this update. With the new object-safe Update, it's possible to use dyn to reduce code bloat for some packet processing, but signature verification requires this crate, which still uses 0.9 :(
Using the current crate with the 0.10 version of
sha2
turns out to be a little messy:It seems like the requirements from this crate are modest, but the change would be quite disruptive (for the same reason) and it might need a version bump. I'd have said a minor release is in order, but you seem to be using major versions for similar changes.
The text was updated successfully, but these errors were encountered: