Skip to content
System contracts CI

Passkey support #2

Sign in to view logs

Passkey support

Passkey support #2

Triggered via pull request September 4, 2024 08:48
@zkJoaquinzkJoaquin
synchronize #16
new-zklink-passkey
Status Failure
Total duration 4m 40s
Artifacts –

system-contracts-ci.yaml

on: pull_request
build
3m 52s
build
lint
39s
lint
check-hashes
30s
check-hashes
test-bootloader
0s
test-bootloader
test-contracts
0s
test-contracts
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 13 warnings
lint: system-contracts/contracts/libraries/PasskeyHelper.sol#L120
Use double quotes for string literals
lint: system-contracts/contracts/libraries/PasskeyHelper.sol#L129
Named parameters missing. MIN unnamed argumenst is 4
lint: system-contracts/contracts/libraries/PasskeyHelper.sol#L153
Named parameters missing. MIN unnamed argumenst is 4
lint
Process completed with exit code 1.
check-hashes
Process completed with exit code 1.
lint
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
lint: l1-contracts/contracts/state-transition/chain-deps/facets/Mailbox.sol#L492
Avoid to use tx.origin
lint: l1-contracts/contracts/vendor/AddressAliasHelper.sol#L55
Avoid to use tx.origin
lint: l1-contracts/test/foundry/unit/concrete/AddressAliasHelper/applyL1ToL2Alias.t.sol#L6
Contract name must be in CamelCase
lint: l1-contracts/test/foundry/unit/concrete/AddressAliasHelper/undoL1ToL2Alias.t.sol#L6
Contract name must be in CamelCase
lint: l1-contracts/test/foundry/unit/concrete/Executor/ExecutorProof.t.sol#L2
Found more than One contract per file. 2 contracts found!
lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/DiamondProxy/DiamondProxy.t.sol#L2
Found more than One contract per file. 2 contracts found!
lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/facets/Admin/ExecuteUpgrade.t.sol#L3
Found more than One contract per file. 2 contracts found!
lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/facets/Base/_Base_Shared.t.sol#L2
Found more than One contract per file. 2 contracts found!
lint: l1-contracts/test/foundry/unit/concrete/state-transition/chain-deps/facets/Getters/_Getters_Shared.t.sol#L2
Found more than One contract per file. 2 contracts found!
lint: l1-contracts/test/foundry/unit/concrete/state-transition/StateTransitionManager/CreateNewChain.t.sol#L7
Contract name must be in CamelCase
build
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/cache/save@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
check-hashes
The following actions use a deprecated Node.js version and will be forced to run on node20: actions/setup-node@v3, actions/cache/restore@v3. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/