feat: Implement MGF1 #115
Merged
feat: Implement MGF1 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @seshanthS This is really cool! I just added the mock passport data for rsassaPss here: https://github.com/zk-passport/proof-of-passport/blob/57ec1c3407ea1f66f348636a68e0d1c6cf914c65/common/src/utils/mockPassportData.ts#L105 If you want to continue working on this, you can now try doing the full implementation for rsassaPss using your mgf1 This would be super valuable, and also a nice way to test it as it's hard for us to know if your implementation follows the same one used in passports unless we test it with a compliant passport data like the one I just added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #109
Tests:
from
proof-of-passport/circuitsdirectory,yarn ts-mocha test/Mgf1_sha256.test.ts