Merge remote-tracking branch 'upstream/main'

* upstream/main: GitHub Actions cleanups (go-gitea#24620) Fix issues list page multiple selection update milestones (go-gitea#24660) Make repo migration cancelable and fix various bugs (go-gitea#24605) Improve queue & process & stacktrace (go-gitea#24636) Fix missing badges in org settings page (go-gitea#24654) Only show one tippy at a time (go-gitea#24648) Reenable creating default webhooks. (go-gitea#24626) Kd/fix redis unit test (go-gitea#24650)
zjjhot · May 12, 2023 · 39754d7 · 39754d7
2 parents cb2de12 + 6c8b680
commit 39754d7
Show file tree

Hide file tree

Showing 46 changed files with 731 additions and 627 deletions.
diff --git a/.github/workflows/cron-licenses.yml b/.github/workflows/cron-licenses.yml
@@ -1,21 +1,20 @@
-name: "Cron: Update licenses and gitignores"
+name: cron-licenses
 
 on:
   schedule:
-    # weekly on Monday at 0:07 UTC
-    - cron: "7 0 * * 1"
+    - cron: "7 0 * * 1" # every Monday at 00:07 UTC
 
 jobs:
-  cron:
+  cron-licenses:
+    if: github.repository == "go-gitea/gitea"
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
-        uses: actions/checkout@v3
+      - uses: actions/checkout@v3
       - uses: actions/setup-go@v3
         with:
-          go-version: '>=1.20.1'
-      - name: update licenses and gitignores
-        run: timeout -s ABRT 40m make generate-license generate-gitignore
+          go-version: ">=1.20.1"
+      - run: make generate-license generate-gitignore
+        timeout-minutes: 40
       - name: push translations to repo
         uses: appleboy/[email protected]
         with:

diff --git a/.github/workflows/lock.yml → .github/workflows/cron-lock.yml b/.github/workflows/lock.yml → .github/workflows/cron-lock.yml
@@ -1,8 +1,8 @@
-name: 'Lock Threads'
+name: cron-lock
 
 on:
   schedule:
-    - cron: '0 0 * * *' # Run once a day
+    - cron: "0 0 * * *" # every day at 00:00 UTC
   workflow_dispatch:
 
 permissions:

diff --git a/.github/workflows/cron-translations.yml b/.github/workflows/cron-translations.yml
@@ -1,15 +1,14 @@
-name: "Cron: Pull translations from Crowdin"
+name: cron-translations
 
 on:
   schedule:
-    - cron: "7 0 * * *" # every day at 0:07 UTC
+    - cron: "7 0 * * *" # every day at 00:07 UTC
 
 jobs:
-  crowdin_pull:
+  crowdin-pull:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
-        uses: actions/checkout@v3
+      - uses: actions/checkout@v3
       - name: download from crowdin
         uses: docker://jonasfranz/crowdin
         env:
@@ -30,11 +29,10 @@ jobs:
           commit_message: "[skip ci] Updated translations via Crowdin"
           remote: "[email protected]:go-gitea/gitea.git"
           ssh_key: ${{ secrets.DEPLOY_KEY }}
-  crowdin_push:
+  crowdin-push:
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout
-        uses: actions/checkout@v3
+      - uses: actions/checkout@v3
       - name: push translations to crowdin
         uses: docker://jonasfranz/crowdin
         env:

diff --git a/.github/workflows/push-publish_docs.yml → .github/workflows/publish-docs.yml b/.github/workflows/push-publish_docs.yml → .github/workflows/publish-docs.yml
@@ -1,4 +1,4 @@
-name: "Docs: Publish"
+name: publish-docs
 
 on:
   push:
@@ -11,12 +11,10 @@ jobs:
   compliance-docs:
     runs-on: ubuntu-latest
     steps:
-      - name: checkout
-        uses: actions/checkout@v3
-      - name: setup go
-        uses: actions/setup-go@v4
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v4
         with:
-          go-version: '>=1.20.1'
+          go-version: ">=1.20.1"
       - name: build docs
         run: |
           cd docs

diff --git a/.github/workflows/pull-compliance-docs.yml b/.github/workflows/pull-compliance-docs.yml
@@ -0,0 +1,22 @@
+name: compliance-docs
+
+on:
+  pull_request:
+    paths:
+      - "docs/**"
+      - "*.md"
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
+  cancel-in-progress: true
+
+jobs:
+  compliance-docs:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
+        with:
+          node-version: 20
+      - run: make deps-frontend
+      - run: make lint-md
diff --git a/.github/workflows/pull-compliance.yml b/.github/workflows/pull-compliance.yml
@@ -1,4 +1,4 @@
-name: "Pull: Compliance Tests"
+name: compliance
 
 on: [pull_request]
 
@@ -7,136 +7,93 @@ concurrency:
   cancel-in-progress: true
 
 jobs:
-  lint_basic:
+  lint-backend:
     runs-on: ubuntu-latest
     steps:
-      - name: checkout
-        uses: actions/checkout@v3
-      - name: setup go
-        uses: actions/setup-go@v4
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v4
         with:
-          go-version: '>=1.20'
+          go-version: ">=1.20"
           check-latest: true
-      - name: deps-backend
-        run: make deps-backend deps-tools
-      - name: lint backend
-        run: make lint-backend
+      - run: make deps-backend deps-tools
+      - run: make lint-backend
         env:
-          GOPROXY: https://goproxy.io # proxy.golang.org is blocked in China, this proxy is not
-          GOSUMDB: sum.golang.org
           TAGS: bindata sqlite sqlite_unlock_notify
-  lint_windows:
+  lint-go-windows:
     runs-on: ubuntu-latest
     steps:
-      - name: checkout
-        uses: actions/checkout@v3
-      - name: setup go
-        uses: actions/setup-go@v4
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v4
         with:
-          go-version: '>=1.20'
+          go-version: ">=1.20"
           check-latest: true
-      - name: deps-backend
-        run: make deps-backend deps-tools
-      - name: lint-backend-windows
-        run: make lint-go-windows lint-go-vet
+      - run: make deps-backend deps-tools
+      - run: make lint-go-windows lint-go-vet
         env:
-          GOPROXY: https://goproxy.io # proxy.golang.org is blocked in China, this proxy is not
-          GOSUMDB: sum.golang.org
           TAGS: bindata sqlite sqlite_unlock_notify
           GOOS: windows
           GOARCH: amd64
-  lint_gogit:
+  lint-go-gogit:
     runs-on: ubuntu-latest
     steps:
-      - name: checkout
-        uses: actions/checkout@v3
-      - name: setup go
-        uses: actions/setup-go@v4
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v4
         with:
-          go-version: '>=1.20'
+          go-version: ">=1.20"
           check-latest: true
-      - name: deps-backend
-        run: make deps-backend deps-tools
-      - name: lint-backend-gogit
-        run: make lint-backend
+      - run: make deps-backend deps-tools
+      - run: make lint-go
         env:
-          GOPROXY: https://goproxy.io # proxy.golang.org is blocked in China, this proxy is not
-          GOSUMDB: sum.golang.org
           TAGS: bindata gogit sqlite sqlite_unlock_notify
-      - name: checks backend
-        run: make --always-make checks-backend # ensure the 'go-licenses' make target runs
-  check_backend:
+  checks-backend:
     runs-on: ubuntu-latest
     steps:
-      - name: checkout
-        uses: actions/checkout@v3
-      - name: setup go
-        uses: actions/setup-go@v4
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v4
         with:
-          go-version: '>=1.20'
+          go-version: ">=1.20"
           check-latest: true
-      - name: deps-backend
-        run: make deps-backend deps-tools
-      - name: checks backend
-        run: make --always-make checks-backend # ensure the 'go-licenses' make target runs
+      - run: make deps-backend deps-tools
+      - run: make --always-make checks-backend # ensure the "go-licenses" make target runs
   frontend:
     runs-on: ubuntu-latest
     steps:
-      - name: checkout
-        uses: actions/checkout@v3
-      - name: setup node
-        uses: actions/setup-node@v3
+      - uses: actions/checkout@v3
+      - uses: actions/setup-node@v3
         with:
           node-version: 20
-      - name: deps-frontend
-        run: make deps-frontend
-      - name: lint frontend
-        run: make lint-frontend
-      - name: checks frontend
-        run: make checks-frontend
-      - name: test frontend
-        run: make test-frontend
+      - run: make deps-frontend
+      - run: make lint-frontend
+      - run: make checks-frontend
   backend:
     runs-on: ubuntu-latest
     steps:
-      - name: checkout
-        uses: actions/checkout@v3
-      - name: setup go
-        uses: actions/setup-go@v4
+      - uses: actions/checkout@v3
+      - uses: actions/setup-go@v4
         with:
-          go-version: '>=1.20'
+          go-version: ">=1.20"
           check-latest: true
-      - name: setup node
-        uses: actions/setup-node@v3
+      - uses: actions/setup-node@v3
         with:
           node-version: 20
-      - name: deps-backend
-        run: make deps-backend deps-tools
-      - name: deps-frontend
-        run: make deps-frontend
-      - name: build frontend
-        run: make frontend
-      - name: build-backend-no-gcc
-        run: go build -o gitea_no_gcc # test if build succeeds without the sqlite tag
-        env:
-          GOPROXY: https://goproxy.io
+      - run: make deps-backend deps-tools
+      - run: make deps-frontend
+      - run: make frontend
+      - run: go build -o gitea_no_gcc # test if build succeeds without the sqlite tag
       - name: build-backend-arm64
         run: make backend # test cross compile
         env:
-          GOPROXY: https://goproxy.io
           GOOS: linux
           GOARCH: arm64
           TAGS: bindata gogit
       - name: build-backend-windows
         run: go build -o gitea_windows
         env:
-          GOPROXY: https://goproxy.io
           GOOS: windows
           GOARCH: amd64
           TAGS: bindata gogit
       - name: build-backend-386
         run: go build -o gitea_linux_386 # test if compatible with 32 bit
         env:
-          GOPROXY: https://goproxy.io
           GOOS: linux
           GOARCH: 386
diff --git a/.github/workflows/pull-compliance_docs.yml b/.github/workflows/pull-compliance_docs.yml