Fix failing specs #500
Merged
Fix failing specs #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why: Trying run the specs on vanilla machine produces error: ``` resource.rb:10:in `block in define_action: undefined method extract_options! for ["/path"]:Array (NoMethodError) ```
Why: Trying to run specs with the old version using `bundle exec rspec` leads to an error: ``` tried to create Proc object without a block faraday-0.9.2/lib/faraday/options.rb:153:in new: tried to create Proc object without a block (ArgumentError) ... ../http_test_client.rb:2:in require ```
Why:
Fixes error when running specs `bundle exec (/home/m/.rbenv/versions/3.1.0/bin/rspec)
bundle exec rspec spec/dsl_spec.rb`
```
NoMethodError:
undefined method `stringify_keys for {:name=>"Friday Order"}:Hash
...
dsl/endpoint.rb:171:in `block in extra_params
```
Why:
Given specs fails on expecting `description` field being empty while
in current version it contains capitalised version of `name` attribute.
```
expected: [{:required=>false, :name=>"description", :description=>nil, :properties_description=>"optional"}]
got: [{:required=>false, :name=>"description", :description=>"Description", :properties_description=>"optional"}]
```
|
merged it, but should have squashed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains fixes for errors that I have encounter when after
bundle installtried to run
bundle exec rspecon the project.The first failure is also present in build for example https://travis-ci.org/github/zipmark/rspec_api_documentation/jobs/762134473