Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backward compatibility to use json or JSON in format configuration #399

Merged
merged 1 commit into from
Sep 4, 2018
Merged

backward compatibility to use json or JSON in format configuration #399

merged 1 commit into from
Sep 4, 2018

Conversation

roramirez
Copy link

issue #382

@oestrich oestrich merged commit 117b82d into zipmark:master Sep 4, 2018
@oestrich
Copy link
Contributor

oestrich commented Sep 4, 2018

Thanks!

@oestrich oestrich mentioned this pull request Sep 4, 2018
Closed
bf4
bf4 reviewed Sep 4, 2018
View reviewed changes
lib/rspec_api_documentation/writers/json_writer.rb
@@ -23,6 +23,10 @@ def write_examples
end
end

# https://github.com/zipmark/rspec_api_documentation/issues/382
# backward compatibilty json for configuration of config.format
class JsonWriter < JSONWriter; end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw, you could just

JsonWriter = JSONWriter

next time

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!, thanks your tip!

@oestrich oestrich mentioned this pull request Sep 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bf4 bf4 bf4 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roramirez @oestrich @bf4