Remove nested uploaded data from request body #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you also change the feature file testing this to scope the file? Just want to make sure there's a test covering this change. |
|
@oestrich Will do |
|
@oestrich made some additions to the features to cover this case |
oestrich
added a commit
that referenced
this pull request
Jan 16, 2014
Remove nested uploaded data from request body
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks for the existence of tempfile data in a nested fashion.
The prior change did not take into account in rails most uploaded file data is buried 2-3 levels deep inside the params. This resolves that issue.
See #39