Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenTracing] Preserve Throwable failures when logging errors #795

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

ghostdogpr
Copy link
Member

This is a follow-up to my previous PR: #786

When the error is already a Throwable, it's a bit pity to wrap it in a FiberFailure because then all errors end up being FiberFailure. When we already have a Throwable, we don't need that wrapping.

@ghostdogpr ghostdogpr requested a review from a team as a code owner January 12, 2024 01:21
Copy link
Contributor

@grouzen grouzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix!

@grouzen grouzen merged commit ab701f0 into zio:series/2.x Jan 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants