-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop Java 8 support && Introduce Java21 #296
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
fa0a489
Drop Java 8 support
guizmaii eb41539
Merge branch 'main' into drop_java_8_support
guizmaii d054017
Drop Java 8 support
guizmaii ceb56f4
Drop Java 8 support
guizmaii 767c2f4
Drop Java 8 support
guizmaii b06b4eb
scalafmt
guizmaii d610b94
Update actions/checkout to v4.1.0
guizmaii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,7 +4,6 @@ | |
| name: CI | ||
| env: | ||
| JDK_JAVA_OPTIONS: -XX:+PrintCommandLineFlags | ||
| JVM_OPTS: -XX:+PrintCommandLineFlags | ||
| 'on': | ||
| workflow_dispatch: {} | ||
| release: | ||
|
|
@@ -21,16 +20,16 @@ jobs: | |
| continue-on-error: true | ||
| steps: | ||
| - name: Git Checkout | ||
| uses: actions/checkout@v4.0.0 | ||
| uses: actions/checkout@v4.1.0 | ||
| with: | ||
| fetch-depth: '0' | ||
| - name: Install libuv | ||
| run: sudo apt-get update && sudo apt-get install -y libuv1-dev | ||
| - name: Setup Scala | ||
| uses: actions/[email protected] | ||
| with: | ||
| distribution: temurin | ||
| java-version: '8' | ||
| distribution: corretto | ||
| java-version: '17' | ||
| check-latest: true | ||
| - name: Cache Dependencies | ||
| uses: coursier/cache-action@v6 | ||
|
|
@@ -46,16 +45,16 @@ jobs: | |
| continue-on-error: false | ||
| steps: | ||
| - name: Git Checkout | ||
| uses: actions/checkout@v4.0.0 | ||
| uses: actions/checkout@v4.1.0 | ||
| with: | ||
| fetch-depth: '0' | ||
| - name: Install libuv | ||
| run: sudo apt-get update && sudo apt-get install -y libuv1-dev | ||
| - name: Setup Scala | ||
| uses: actions/[email protected] | ||
| with: | ||
| distribution: temurin | ||
| java-version: '8' | ||
| distribution: corretto | ||
| java-version: '17' | ||
| check-latest: true | ||
| - name: Cache Dependencies | ||
| uses: coursier/cache-action@v6 | ||
|
|
@@ -71,22 +70,22 @@ jobs: | |
| fail-fast: false | ||
| matrix: | ||
| java: | ||
| - '8' | ||
| - '11' | ||
| - '17' | ||
| - '21' | ||
| steps: | ||
| - name: Install libuv | ||
| run: sudo apt-get update && sudo apt-get install -y libuv1-dev | ||
| - name: Setup Scala | ||
| uses: actions/[email protected] | ||
| with: | ||
| distribution: temurin | ||
| distribution: corretto | ||
| java-version: ${{ matrix.java }} | ||
| check-latest: true | ||
| - name: Cache Dependencies | ||
| uses: coursier/cache-action@v6 | ||
| - name: Git Checkout | ||
| uses: actions/checkout@v4.0.0 | ||
| uses: actions/checkout@v4.1.0 | ||
| with: | ||
| fetch-depth: '0' | ||
| - name: Test | ||
|
|
@@ -98,16 +97,16 @@ jobs: | |
| if: ${{ github.event_name == 'push' }} | ||
| steps: | ||
| - name: Git Checkout | ||
| uses: actions/checkout@v4.0.0 | ||
| uses: actions/checkout@v4.1.0 | ||
| with: | ||
| fetch-depth: '0' | ||
| - name: Install libuv | ||
| run: sudo apt-get update && sudo apt-get install -y libuv1-dev | ||
| - name: Setup Scala | ||
| uses: actions/[email protected] | ||
| with: | ||
| distribution: temurin | ||
| java-version: '8' | ||
| distribution: corretto | ||
| java-version: '17' | ||
| check-latest: true | ||
| - name: Cache Dependencies | ||
| uses: coursier/cache-action@v6 | ||
|
|
@@ -172,16 +171,16 @@ jobs: | |
| if: ${{ github.event_name != 'pull_request' }} | ||
| steps: | ||
| - name: Git Checkout | ||
| uses: actions/checkout@v4.0.0 | ||
| uses: actions/checkout@v4.1.0 | ||
| with: | ||
| fetch-depth: '0' | ||
| - name: Install libuv | ||
| run: sudo apt-get update && sudo apt-get install -y libuv1-dev | ||
| - name: Setup Scala | ||
| uses: actions/[email protected] | ||
| with: | ||
| distribution: temurin | ||
| java-version: '8' | ||
| distribution: corretto | ||
| java-version: '17' | ||
| check-latest: true | ||
| - name: Cache Dependencies | ||
| uses: coursier/cache-action@v6 | ||
|
|
@@ -201,16 +200,16 @@ jobs: | |
| if: ${{ ((github.event_name == 'release') && (github.event.action == 'published')) || (github.event_name == 'workflow_dispatch') }} | ||
| steps: | ||
| - name: Git Checkout | ||
| uses: actions/checkout@v4.0.0 | ||
| uses: actions/checkout@v4.1.0 | ||
| with: | ||
| fetch-depth: '0' | ||
| - name: Install libuv | ||
| run: sudo apt-get update && sudo apt-get install -y libuv1-dev | ||
| - name: Setup Scala | ||
| uses: actions/[email protected] | ||
| with: | ||
| distribution: temurin | ||
| java-version: '8' | ||
| distribution: corretto | ||
| java-version: '17' | ||
| check-latest: true | ||
| - name: Cache Dependencies | ||
| uses: coursier/cache-action@v6 | ||
|
|
@@ -232,7 +231,7 @@ jobs: | |
| if: ${{ (github.event_name == 'release') && (github.event.action == 'published') }} | ||
| steps: | ||
| - name: Git Checkout | ||
| uses: actions/checkout@v4.0.0 | ||
| uses: actions/checkout@v4.1.0 | ||
| with: | ||
| fetch-depth: '0' | ||
| - name: notify the main repo about the new release of docs package | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -140,23 +140,20 @@ test: | |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| java: | ||
| - '8' | ||
| - '11' | ||
| - '17' | ||
| java: ['11', '17', '21'] | ||
| steps: | ||
| - name: Install libuv | ||
| run: sudo apt-get update && sudo apt-get install -y libuv1-dev | ||
| - name: Setup Scala | ||
| uses: actions/[email protected] | ||
| with: | ||
| distribution: temurin | ||
| distribution: corretto | ||
| java-version: ${{ matrix.java }} | ||
| check-latest: true | ||
| - name: Cache Dependencies | ||
| uses: coursier/cache-action@v6 | ||
| - name: Git Checkout | ||
| uses: actions/checkout@v4.0.0 | ||
| uses: actions/checkout@v4.1.0 | ||
| with: | ||
| fetch-depth: '0' | ||
| - name: Test | ||
|
|
@@ -171,12 +168,12 @@ In some cases, we may have multiple submodules in our project and we want to tes | |
|
|
||
| The `ciTargetScalaVersions` setting key is used to define a mapping of project names to the Scala versions that should be used for testing phase of continuous integration (CI). | ||
|
|
||
| For example, suppose we have a project with the name "submoduleA" and we want to test it against Scala `2.12.18`, and for the "submoduleB" we want to test it against Scala `2.12.18` and `2.13.11` and `3.3.0`, We can define the `ciTargetScalaVersions` setting as follows: | ||
| For example, suppose we have a project with the name "submoduleA" and we want to test it against Scala `2.12.18`, and for the "submoduleB" we want to test it against Scala `2.12.18` and `2.13.12` and `3.3.1`, We can define the `ciTargetScalaVersions` setting as follows: | ||
|
|
||
| ```scala | ||
| ThisBuild / ciTargetScalaVersions := Map( | ||
| "submoduleA" -> Seq("2.12.18"), | ||
| "submoduleB" -> Seq("2.12.18", "2.13.11", "3.3.0") | ||
| "submoduleB" -> Seq("2.12.18", "2.13.12", "3.3.1") | ||
| ) | ||
| ``` | ||
|
|
||
|
|
@@ -207,28 +204,25 @@ test: | |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| java: | ||
| - '8' | ||
| - '11' | ||
| - '17' | ||
| java: ['11', '17', '21'] | ||
| scala-project: | ||
| - ++2.12.18 submoduleA | ||
| - ++2.12.18 submoduleB | ||
| - ++2.13.11 submoduleB | ||
| - ++3.3.0 submoduleB | ||
| - ++2.13.12 submoduleB | ||
| - ++3.3.1 submoduleB | ||
| steps: | ||
| - name: Install libuv | ||
| run: sudo apt-get update && sudo apt-get install -y libuv1-dev | ||
| - name: Setup Scala | ||
| uses: actions/[email protected] | ||
| with: | ||
| distribution: temurin | ||
| distribution: corretto | ||
| java-version: ${{ matrix.java }} | ||
| check-latest: true | ||
| - name: Cache Dependencies | ||
| uses: coursier/cache-action@v6 | ||
| - name: Git Checkout | ||
| uses: actions/checkout@v4.0.0 | ||
| uses: actions/checkout@v4.1.0 | ||
| with: | ||
| fetch-depth: '0' | ||
| - name: Test | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -138,24 +138,20 @@ test: | |
| continue-on-error: false | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| java: | ||
| - '8' | ||
| - '11' | ||
| - '17' | ||
| java: ['11', '17', '21'] | ||
| steps: | ||
| - name: Install libuv | ||
| run: sudo apt-get update && sudo apt-get install -y libuv1-dev | ||
| - name: Setup Scala | ||
| uses: actions/[email protected] | ||
| with: | ||
| distribution: temurin | ||
| distribution: corretto | ||
| java-version: ${{ matrix.java }} | ||
| check-latest: true | ||
| - name: Cache Dependencies | ||
| uses: coursier/cache-action@v6 | ||
| - name: Git Checkout | ||
| uses: actions/checkout@v4.0.0 | ||
| uses: actions/checkout@v4.1.0 | ||
| with: | ||
| fetch-depth: '0' | ||
| - name: Test | ||
|
|
@@ -170,12 +166,12 @@ In some cases, we may have multiple submodules in our project and we want to tes | |
|
|
||
| The `ciTargetScalaVersions` setting key is used to define a mapping of project names to the Scala versions that should be used for testing phase of continuous integration (CI). | ||
|
|
||
| For example, suppose we have a project with the name "submoduleA" and we want to test it against Scala `2.12.18`, and for the "submoduleB" we want to test it against Scala `2.12.18` and `2.13.11` and `3.3.0`, We can define the `ciTargetScalaVersions` setting as follows: | ||
| For example, suppose we have a project with the name "submoduleA" and we want to test it against Scala `2.12.18`, and for the "submoduleB" we want to test it against Scala `2.12.18` and `2.13.12` and `3.3.1`, We can define the `ciTargetScalaVersions` setting as follows: | ||
|
|
||
| ```scala | ||
| ThisBuild / ciTargetScalaVersions := Map( | ||
| "submoduleA" -> Seq("2.12.18"), | ||
| "submoduleB" -> Seq("2.12.18", "2.13.11", "3.3.0") | ||
| "submoduleB" -> Seq("2.12.18", "2.13.12", "3.3.1") | ||
| ) | ||
| ``` | ||
|
|
||
|
|
@@ -206,28 +202,25 @@ test: | |
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| java: | ||
| - '8' | ||
| - '11' | ||
| - '17' | ||
| java: ['11', '17', '21'] | ||
| scala-project: | ||
| - ++2.12.18 submoduleA | ||
| - ++2.12.18 submoduleB | ||
| - ++2.13.11 submoduleB | ||
| - ++3.3.0 submoduleB | ||
| - ++2.13.12 submoduleB | ||
| - ++3.3.1 submoduleB | ||
| steps: | ||
| - name: Install libuv | ||
| run: sudo apt-get update && sudo apt-get install -y libuv1-dev | ||
| - name: Setup Scala | ||
| uses: actions/[email protected] | ||
| with: | ||
| distribution: temurin | ||
| distribution: corretto | ||
| java-version: ${{ matrix.java }} | ||
| check-latest: true | ||
| - name: Cache Dependencies | ||
| uses: coursier/cache-action@v6 | ||
| - name: Git Checkout | ||
| uses: actions/checkout@v4.0.0 | ||
| uses: actions/checkout@v4.1.0 | ||
| with: | ||
| fetch-depth: '0' | ||
| - name: Test | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| object Versions { | ||
| val Scala212 = "2.12.18" | ||
| val Scala213 = "2.13.11" | ||
| val Scala3 = "3.3.0" | ||
| val zio = "2.0.16" | ||
| val Scala213 = "2.13.12" | ||
| val Scala3 = "3.3.1" | ||
| val zio = "2.0.17" | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
temurindidn't publish their version of Java 21 yet