Add support for defining metadata #90
Conversation
src/main/scala/zio/s3/package.scala
Outdated
| @@ -130,7 +132,8 @@ package object s3 { | |||
| bucketName: String, | |||
| key: String, | |||
| contentType: String, | |||
| content: ZStream[R, Throwable, Byte] | |||
| content: ZStream[R, Throwable, Byte], | |||
| metadata: Map[String, String] | |||
There was a problem hiding this comment.
a default value would be great
metadata: Map[String, String] = Map.empty
| @@ -169,7 +169,7 @@ object S3Suite { | |||
| val tmpKey = Random.alphanumeric.take(10).mkString | |||
|
|
|||
| for { | |||
| _ <- putObject(bucketName, tmpKey, c.length.toLong, "text/plain", data) | |||
| _ <- putObject(bucketName, tmpKey, c.length.toLong, "text/plain", data, metadata = Map.empty) | |||
There was a problem hiding this comment.
also coud you add another test to verify metadata are set on the file
|
No problem @regis-leray, glad to help. I'll definitely continue to contribute ;) I added the defaults for the metadata 6a023d3. For the metadata proper test it might involve a bit more work since the s3 is emulated with the file system. I would need to think of some smarter way how to store the metadata apart from the file, either a separate shadow bucket or file or something similar. Given that it's just a pass of a value to the async client would it be possible that the version is released with the metadata support and I open a ticket to make the test since I have a deadline and I would really like to use the zio-s3 in my case and not use something else or roll my own stuff directly with the aws client? |
|
oki thanks. @msvaljek you will be able to use the snapshot release. thanks |
I'm working on a project where I need to update the metadata to do something business relevant.
I thought about going around this one similar to how I'm already fetching the metadata i.e. by using
executebut as you can see here this is only possible if I copy the file again, this is not optimal for my use-case.This needs to be provided when creating the s3 object as seen here: https://stackoverflow.com/a/32646827/7413631
For now, I just added what I need, i.e. a map of metadata, possibly we could think about some quality tests/type safety.