[FEATURE] Add contentMD5 for putObject to support object locking
#394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
regis-leray
approved these changes
Jan 27, 2023
|
@tPl0ch can you please fix the javadoc thank you |
We are hitting an error when using this library because our bucket is configured with [object locking](https://docs.aws.amazon.com/AmazonS3/latest/userguide/object-lock.html): ``` Content-MD5 OR x-amz-checksum- HTTP header is required for Put Object requests with Object Lock parameters (Service: S3, Status Code: 400, Request ID: XXX, Extended Request ID: XXX) ``` The AWS S3 API requires passing the `Content-MD5` option for `putObject` requests that target buckets with object locking enabled. From the [`putObject` API description](https://docs.aws.amazon.com/AmazonS3/latest/API/API_PutObject.html): > To ensure that data is not corrupted traversing the network, use the Content-MD5 header. When you use this header, Amazon S3 checks the object against the provided MD5 value and, if they do not match, returns an error. Additionally, you can calculate the MD5 while putting an object to Amazon S3 and compare the returned ETag to the calculated MD5 value. > The Content-MD5 header is required for any request to upload an object with a retention period configured using Amazon S3 Object Lock. For more information about Amazon S3 Object Lock, see Amazon S3 Object Lock Overview in the Amazon S3 User Guide. This MR adds a BC support for passing an `Option[String]` as contentMD5, which is a base64 encoded MD5 hash. The library users will be responsible to provide a correct contentMD5.
tPl0ch
force-pushed
the
feature-content-md5
branch
from
248dd25 to
58d2ea2
Compare
|
@regis-leray done. Thanks for the quick response, much appreciated! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We are hitting an error when using this library because our bucket is configured with object locking:
The AWS S3 API requires passing the
Content-MD5option forputObjectrequests that target buckets with object locking enabled.From the
putObjectAPI description:This MR adds a BC support for passing an
Option[String]as contentMD5, which is a base64 encoded MD5 hash. The library users will be responsible to provide a correct contentMD5.Urgency
This is extremely urgent for us since it blocks the go-live of an important project. So if you @regis-leray could have a look shortly and hopefully merge this change to the lib we could use a snapshot version to start our go-live. Thank you very much in advance!