[STUB] getObjectMetadata should also refine FileNotFoundException
#386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tPl0ch
force-pushed
the
ft-exception-type-stub
branch
3 times, most recently
from
4225e40 to
7591f4e
Compare
While working on a use-case in which we first check for object existence via `getObjectMetadata` before we use `putObject` in order to save bandwidth, I realized that when using the test stub the tests were failing with an `NoSuchFileException`. This was due to the fact that `getObjectMetadata` does not refine the `NoSuchFileException` like `getObject` does with `FileNotFoundException`. This commit adds refinement of these exceptions to `getObjectMetadata` analogous to `getObject`. The `fileNotFound` function needs to be adapted to `Throwable` because `java.nio.*` and `java.io.*` do not share an error hierarchy.
tPl0ch
force-pushed
the
ft-exception-type-stub
branch
from
7591f4e to
393d1ab
Compare
regis-leray
approved these changes
Jan 17, 2023
|
@regis-leray I guess you also need to approve the CI workflows since I am a first time contributor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While working on a use-case in which we first check for object existence via
getObjectMetadatabefore we useputObjectin order to save bandwidth, Irealized that when using the test stub the tests were failing with an
NoSuchFileException.This was due to the fact that
getObjectMetadatadoes not refine theNoSuchFileExceptionlikegetObjectdoes withFileNotFoundException.This commit adds refinement of these exceptions to
getObjectMetadataanalogous to
getObject. ThefileNotFoundfunction needs to be adaptedto
Throwablebecausejava.nio.*andjava.io.*do not share an errorhierarchy.