Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use environment in connect and liveM #218

Merged
merged 2 commits into from
May 14, 2021
Merged

use environment in connect and liveM #218

merged 2 commits into from
May 14, 2021

Conversation

sirocchj
Copy link
Contributor

@sirocchj sirocchj commented May 14, 2021 •
edited
Loading

I noticed that some of the examples in the quickstart don't work, see here.
Added test to assert it can be constructed (fails on current 0.3.2) and implemented needed change.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@regis-leray
Copy link
Member

thank you

@regis-leray regis-leray self-requested a review May 14, 2021 12:32
@regis-leray regis-leray merged commit 4dc454d into zio:master May 14, 2021
@sirocchj sirocchj deleted the fix-live branch May 14, 2021 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@regis-leray regis-leray regis-leray approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirocchj @CLAassistant @regis-leray