Concrete run method signatures in contexts #83
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In previous version of ProtoQuill there was no InternalApi and the
run
methods were usedon a context directly. This caused a problem where doing something like:
Will yield:
This was even worse if the types were more complex e.g. for ZIO:
Will yield:
This is quite confusing. Therefore we define the methods in an object and then
delegate to these in the individual contexts.
That way the correct type will be asked for: