Implementing multi-row insert for liftQuery(...).foreach #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
analytically
reviewed
Aug 5, 2022
| @@ -78,7 +78,7 @@ trait JdbcContextVerbExecute[+Dialect <: SqlIdiom, +Naming <: NamingStrategy] ex | |||
| groups.flatMap { | |||
| case BatchGroup(sql, prepare) => | |||
| val ps = conn.prepareStatement(sql) | |||
| logger.underlying.debug("Batch: {}", sql) | |||
| //logger.underlying.debug("Batch: {}", sql.take(200) + (if (sql.length > 200) "..." else "")) | |||
There was a problem hiding this comment.
Whoops. I’ll fix that
analytically
reviewed
Aug 5, 2022
| @@ -0,0 +1,7 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # Make the Postgres DB image have 100ms latency for all requests. | |||
|
Are all variables sanitized ? I cannot find anything related. For jdbc, it is safe to execute via |
This was referenced Aug 8, 2022
Have a look at Particularize. It's like an advanced version of ReifyLiftings.
I'm only supporting this functionality for JDBC contexts for now. This will need to be tested separately for Jasync and others. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also Fixing: zio/zio-quill#1269 for ProtoQuill
Implementing multi-insertion capabilities for most contexts via the VALUES (clauseA), (clauseB), (clauseC), etc... construct. The performance benefits of this when working of a network with any kind of real latency are significant e.g. insertion of 1 million rows goes down from 6.6 minutes to 10 seconds!